From: Scott Wood <oss@buserror.net>
To: "Nora Björklund" <nora.bjorklund@enea.com>,
linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org
Subject: Re: [PATCH] powerpc:dts:p2041rdb: enable gpio-expander
Date: Mon, 21 Mar 2016 12:58:00 -0500 [thread overview]
Message-ID: <1458583080.19333.11.camel@buserror.net> (raw)
In-Reply-To: <1458557331-59540-1-git-send-email-nora.bjorklund@enea.com>
On Mon, 2016-03-21 at 11:48 +0100, Nora Björklund wrote:
> Enable the gpio-expander pca9672 on p2041rdb. The expander
> has been present on the p2041rdb all along, however not in
> the device tree.
>
> Signed-off-by: Nora Björklund <nora.bjorklund@enea.com>
> ---
> arch/powerpc/boot/dts/fsl/p2041rdb.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/powerpc/boot/dts/fsl/p2041rdb.dts
> b/arch/powerpc/boot/dts/fsl/p2041rdb.dts
> index e9bd894..b1ee561 100644
> --- a/arch/powerpc/boot/dts/fsl/p2041rdb.dts
> +++ b/arch/powerpc/boot/dts/fsl/p2041rdb.dts
> @@ -134,6 +134,13 @@
> };
> };
>
> + i2c@119100 {
> + gpio@22 {
> + compatible = "pcf8575";
> + reg = <0x22>;
> + };
> + };
The compatible should be "nxp,pcf8575" and it needs the gpio-controller and
#gpio-cells properties.
Is there an interrupt line connected to it?
See Documentation/devicetree/bindings/gpio/gpio-pcf857x.txt
-Scott
next prev parent reply other threads:[~2016-03-21 17:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 10:48 [PATCH] powerpc:dts:p2041rdb: enable gpio-expander Nora Björklund
2016-03-21 17:58 ` Scott Wood [this message]
2016-03-22 9:26 ` Nora Björklund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458583080.19333.11.camel@buserror.net \
--to=oss@buserror.net \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nora.bjorklund@enea.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).