From: Russell Currey <ruscur@russell.cc>
To: Michael Ellerman <mpe@ellerman.id.au>, linuxppc-dev@lists.ozlabs.org
Subject: Re: pseries/eeh: Handle RTAS delay requests in configure_bridge
Date: Thu, 24 Mar 2016 10:56:14 +1100 [thread overview]
Message-ID: <1458777374.5888.3.camel@russell.cc> (raw)
In-Reply-To: <1458729597.13990.4.camel@ellerman.id.au>
On Wed, 2016-03-23 at 21:39 +1100, Michael Ellerman wrote:
> On Wed, 2016-03-23 at 13:52 +1100, Russell Currey wrote:
> >
> > On Wed, 2016-03-23 at 11:38 +1100, Michael Ellerman wrote:
> > >
> > > On Tue, 2016-22-03 at 00:34:55 UTC, Russell Currey wrote:
> > > >
> > > >
> > > > + case RTAS_EXTENDED_DELAY_MIN+2:
> > > > + mwait = 100;
> > > > + break;
> > > > + default:
> > > > + goto err;
> > > > + }
> > > > +
> > > > + max_wait -= mwait;
> > > > + msleep(mwait);
> >
> > >
> > > Can you use rtas_busy_delay() ?
> > Wasn't aware of that, makes life a lot easier. Do you know if the 0.2s
> > maximum delay also applies across the board? I definitely want to
> > enforce
> > it here, but if it is ubiquitous then it should be in rtas_busy_delay.
> Not sure sorry, you'll have to read PAPR :)
It doesn't mention anything, but I was more concerned about whether it's
ever sensible to have that much of a sleep in any case. Probably safe to
ignore given it hasn't been a problem up to this point.
>
> cheers
>
prev parent reply other threads:[~2016-03-23 23:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 0:34 [PATCH] pseries/eeh: Handle RTAS delay requests in configure_bridge Russell Currey
2016-03-23 0:28 ` Russell Currey
2016-03-23 0:38 ` Michael Ellerman
2016-03-23 2:52 ` Russell Currey
2016-03-23 10:39 ` Michael Ellerman
2016-03-23 23:56 ` Russell Currey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458777374.5888.3.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).