From: Russell Currey <ruscur@russell.cc>
To: Gavin Shan <gwshan@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 1/2] pseries/eeh: Refactor the configure bridge RTAS tokens
Date: Tue, 29 Mar 2016 15:53:19 +1000 [thread overview]
Message-ID: <1459230799.21529.2.camel@russell.cc> (raw)
In-Reply-To: <20160329052608.GA2614@gwshan>
On Tue, 2016-03-29 at 16:26 +1100, Gavin Shan wrote:
> On Tue, Mar 29, 2016 at 12:51:50PM +1000, Russell Currey wrote:
<snip>
> > /*
> > * Necessary sanity check. We needn't check "get-config-addr-info"
> > @@ -93,8 +98,7 @@ static int pseries_eeh_init(void)
> > (ibm_read_slot_reset_state2 == RTAS_UNKNOWN_SERVICE &&
> > ibm_read_slot_reset_state == RTAS_UNKNOWN_SERVICE) ||
> > ibm_slot_error_detail == RTAS_UNKNOWN_SERVICE ||
> > - (ibm_configure_pe == RTAS_UNKNOWN_SERVICE &
> > &
> > - ibm_configure_bridge == RTAS_UNKNOWN_SERVICE)) {
> > + ibm_configure_pe == RTAS_UNKNOWN_SERVICE) {
> > pr_info("EEH functionality not supported\n");
> > return -EINVAL;
> > }
> Since you're here, you can do similar thing to @ibm_read_slot_reset_state
> and @ibm_read_slot_reset_state?
Ah, didn't notice there was a similar thing going on there. Will fix.
>
> >
> > @@ -621,18 +625,9 @@ static int pseries_eeh_configure_bridge(struct
> > eeh_pe *pe)
> > if (pe->addr)
> > config_addr = pe->addr;
> >
> > - /* Use new configure-pe function, if supported */
> > - if (ibm_configure_pe != RTAS_UNKNOWN_SERVICE) {
> > - ret = rtas_call(ibm_configure_pe, 3, 1, NULL,
> > - config_addr, BUID_HI(pe->phb->buid),
> > - BUID_LO(pe->phb->buid));
> > - } else if (ibm_configure_bridge != RTAS_UNKNOWN_SERVICE) {
> > - ret = rtas_call(ibm_configure_bridge, 3, 1, NULL,
> > - config_addr, BUID_HI(pe->phb->buid),
> > - BUID_LO(pe->phb->buid));
> > - } else {
> > - return -EFAULT;
> > - }
> > + ret = rtas_call(ibm_configure_pe, 3, 1, NULL,
> > + config_addr, BUID_HI(pe->phb->buid),
> > + BUID_LO(pe->phb->buid));
> >
> Russell, it seems not working if "ibm,configure-pe" and "ibm,configure-
> bridge" are all
> missed from "/rtas".
If they're both missing, then the init should fail as ibm_configure_pe will
be RTAS_UNKNOWN_SERVICE, so this code should never be called.
> Also, I don't think we need backport it to 3.10+ as it's not fixing
> any bugs if I'm correct enough.
This patch doesn't, but the second patch does.
>
> Thanks,
> Gavin
>
>
> >
> > if (ret)
> > pr_warn("%s: Unable to configure bridge PHB#%d-PE#%x
> > (%d)\n",
next prev parent reply other threads:[~2016-03-29 5:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 2:51 [PATCH V2 1/2] pseries/eeh: Refactor the configure bridge RTAS tokens Russell Currey
2016-03-29 2:51 ` [PATCH V2 2/2] pseries/eeh: Handle RTAS delay requests in configure_bridge Russell Currey
2016-03-29 9:49 ` Gavin Shan
2016-03-29 22:01 ` Russell Currey
2016-03-29 23:07 ` Gavin Shan
2016-03-29 15:51 ` Tyrel Datwyler
2016-03-29 21:58 ` Russell Currey
2016-03-29 5:26 ` [PATCH V2 1/2] pseries/eeh: Refactor the configure bridge RTAS tokens Gavin Shan
2016-03-29 5:53 ` Russell Currey [this message]
2016-03-29 9:26 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459230799.21529.2.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).