linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Scott Wood <oss@buserror.net>
To: Zhiqiang Hou <Zhiqiang.Hou@nxp.com>,
	linuxppc-dev@lists.ozlabs.org, benh@kernel.crashing.org,
	paulus@samba.org, mpe@ellerman.id.au
Cc: Mingkai.Hu@nxp.com
Subject: Re: [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash
Date: Wed, 06 Apr 2016 17:01:29 -0500	[thread overview]
Message-ID: <1459980089.32510.78.camel@buserror.net> (raw)
In-Reply-To: <1459937676-25668-1-git-send-email-Zhiqiang.Hou@nxp.com>

On Wed, 2016-04-06 at 18:14 +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> 
> Disable the subsector (4KiB) erase granularity to speed up the erase
> operation.
> 
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
>  arch/powerpc/configs/85xx-hw.config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx
> -hw.config
> index 528ff0e..a0f4e70 100644
> --- a/arch/powerpc/configs/85xx-hw.config
> +++ b/arch/powerpc/configs/85xx-hw.config
> @@ -77,6 +77,7 @@ CONFIG_MTD_PHYSMAP_OF=y
>  CONFIG_MTD_PHYSMAP=y
>  CONFIG_MTD_PLATRAM=y
>  CONFIG_MTD_SPI_NOR=y
> +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
>  CONFIG_NETDEVICES=y
>  CONFIG_NVRAM=y
>  CONFIG_PATA_ALI=y

Is there a reason specific to 85xx to have a different default than every
other platform except lpc18xx?  The description of MTD_SPI_NOR_USE_4K_SECTORS
acknowledges that erase speed is a tradeoff.  Why is that concern more
compelling on 85xx than elsewhere?

-Scott

  reply	other threads:[~2016-04-06 22:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-06 10:14 [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash Zhiqiang Hou
2016-04-06 22:01 ` Scott Wood [this message]
2016-04-07  3:17   ` Zhiqiang Hou
2016-04-08 16:01     ` David Laight
2016-04-11  5:25       ` Zhiqiang Hou
2016-04-17  1:58     ` Scott Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1459980089.32510.78.camel@buserror.net \
    --to=oss@buserror.net \
    --cc=Mingkai.Hu@nxp.com \
    --cc=Zhiqiang.Hou@nxp.com \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).