* [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata
@ 2016-04-08 4:54 Alexey Kardashevskiy
2016-04-08 5:00 ` David Gibson
2016-04-28 18:33 ` Alex Williamson
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Kardashevskiy @ 2016-04-08 4:54 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Alexey Kardashevskiy, Alex Williamson, David Gibson, kvm
This removes iommu_group_get_iommudata() as the result is never used.
As this is a minor cleanup, no change in behavior is expected.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
drivers/vfio/vfio_iommu_spapr_tce.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
index 0582b72..6419566 100644
--- a/drivers/vfio/vfio_iommu_spapr_tce.c
+++ b/drivers/vfio/vfio_iommu_spapr_tce.c
@@ -331,14 +331,12 @@ static void tce_iommu_free_table(struct iommu_table *tbl);
static void tce_iommu_release(void *iommu_data)
{
struct tce_container *container = iommu_data;
- struct iommu_table_group *table_group;
struct tce_iommu_group *tcegrp;
long i;
while (tce_groups_attached(container)) {
tcegrp = list_first_entry(&container->group_list,
struct tce_iommu_group, next);
- table_group = iommu_group_get_iommudata(tcegrp->grp);
tce_iommu_detach_group(iommu_data, tcegrp->grp);
}
--
2.5.0.rc3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata
2016-04-08 4:54 [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata Alexey Kardashevskiy
@ 2016-04-08 5:00 ` David Gibson
2016-04-28 18:33 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: David Gibson @ 2016-04-08 5:00 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: linuxppc-dev, Alex Williamson, kvm
[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]
On Fri, Apr 08, 2016 at 02:54:41PM +1000, Alexey Kardashevskiy wrote:
> This removes iommu_group_get_iommudata() as the result is never used.
> As this is a minor cleanup, no change in behavior is expected.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> drivers/vfio/vfio_iommu_spapr_tce.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
> index 0582b72..6419566 100644
> --- a/drivers/vfio/vfio_iommu_spapr_tce.c
> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c
> @@ -331,14 +331,12 @@ static void tce_iommu_free_table(struct iommu_table *tbl);
> static void tce_iommu_release(void *iommu_data)
> {
> struct tce_container *container = iommu_data;
> - struct iommu_table_group *table_group;
> struct tce_iommu_group *tcegrp;
> long i;
>
> while (tce_groups_attached(container)) {
> tcegrp = list_first_entry(&container->group_list,
> struct tce_iommu_group, next);
> - table_group = iommu_group_get_iommudata(tcegrp->grp);
> tce_iommu_detach_group(iommu_data, tcegrp->grp);
> }
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata
2016-04-08 4:54 [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata Alexey Kardashevskiy
2016-04-08 5:00 ` David Gibson
@ 2016-04-28 18:33 ` Alex Williamson
1 sibling, 0 replies; 3+ messages in thread
From: Alex Williamson @ 2016-04-28 18:33 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: linuxppc-dev, David Gibson, kvm
On Fri, 8 Apr 2016 14:54:41 +1000
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> This removes iommu_group_get_iommudata() as the result is never used.
> As this is a minor cleanup, no change in behavior is expected.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> drivers/vfio/vfio_iommu_spapr_tce.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/vfio/vfio_iommu_spapr_tce.c b/drivers/vfio/vfio_iommu_spapr_tce.c
> index 0582b72..6419566 100644
> --- a/drivers/vfio/vfio_iommu_spapr_tce.c
> +++ b/drivers/vfio/vfio_iommu_spapr_tce.c
> @@ -331,14 +331,12 @@ static void tce_iommu_free_table(struct iommu_table *tbl);
> static void tce_iommu_release(void *iommu_data)
> {
> struct tce_container *container = iommu_data;
> - struct iommu_table_group *table_group;
> struct tce_iommu_group *tcegrp;
> long i;
>
> while (tce_groups_attached(container)) {
> tcegrp = list_first_entry(&container->group_list,
> struct tce_iommu_group, next);
> - table_group = iommu_group_get_iommudata(tcegrp->grp);
> tce_iommu_detach_group(iommu_data, tcegrp->grp);
> }
>
Applied to next with David's R-b for v4.7. Thanks,
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-28 18:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-08 4:54 [PATCH kernel] vfio_iommu_spapr_tce: Remove unneeded iommu_group_get_iommudata Alexey Kardashevskiy
2016-04-08 5:00 ` David Gibson
2016-04-28 18:33 ` Alex Williamson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).