* [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash
@ 2016-04-06 10:14 Zhiqiang Hou
2016-04-06 22:01 ` Scott Wood
0 siblings, 1 reply; 6+ messages in thread
From: Zhiqiang Hou @ 2016-04-06 10:14 UTC (permalink / raw)
To: linuxppc-dev, benh, paulus, mpe, scottwood; +Cc: Mingkai.Hu, Hou Zhiqiang
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Disable the subsector (4KiB) erase granularity to speed up the erase
operation.
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
arch/powerpc/configs/85xx-hw.config | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx-hw.config
index 528ff0e..a0f4e70 100644
--- a/arch/powerpc/configs/85xx-hw.config
+++ b/arch/powerpc/configs/85xx-hw.config
@@ -77,6 +77,7 @@ CONFIG_MTD_PHYSMAP_OF=y
CONFIG_MTD_PHYSMAP=y
CONFIG_MTD_PLATRAM=y
CONFIG_MTD_SPI_NOR=y
+# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
CONFIG_NETDEVICES=y
CONFIG_NVRAM=y
CONFIG_PATA_ALI=y
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash
2016-04-06 10:14 [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash Zhiqiang Hou
@ 2016-04-06 22:01 ` Scott Wood
2016-04-07 3:17 ` Zhiqiang Hou
0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2016-04-06 22:01 UTC (permalink / raw)
To: Zhiqiang Hou, linuxppc-dev, benh, paulus, mpe; +Cc: Mingkai.Hu
On Wed, 2016-04-06 at 18:14 +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> Disable the subsector (4KiB) erase granularity to speed up the erase
> operation.
>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> arch/powerpc/configs/85xx-hw.config | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/configs/85xx-hw.config b/arch/powerpc/configs/85xx
> -hw.config
> index 528ff0e..a0f4e70 100644
> --- a/arch/powerpc/configs/85xx-hw.config
> +++ b/arch/powerpc/configs/85xx-hw.config
> @@ -77,6 +77,7 @@ CONFIG_MTD_PHYSMAP_OF=y
> CONFIG_MTD_PHYSMAP=y
> CONFIG_MTD_PLATRAM=y
> CONFIG_MTD_SPI_NOR=y
> +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
> CONFIG_NETDEVICES=y
> CONFIG_NVRAM=y
> CONFIG_PATA_ALI=y
Is there a reason specific to 85xx to have a different default than every
other platform except lpc18xx? The description of MTD_SPI_NOR_USE_4K_SECTORS
acknowledges that erase speed is a tradeoff. Why is that concern more
compelling on 85xx than elsewhere?
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash
2016-04-06 22:01 ` Scott Wood
@ 2016-04-07 3:17 ` Zhiqiang Hou
2016-04-08 16:01 ` David Laight
2016-04-17 1:58 ` Scott Wood
0 siblings, 2 replies; 6+ messages in thread
From: Zhiqiang Hou @ 2016-04-07 3:17 UTC (permalink / raw)
To: Scott Wood, linuxppc-dev@lists.ozlabs.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: Mingkai Hu
SGkgU2NvdHQsDQoNClRoYW5rcyBmb3IgeW91ciBjb21tZW50cy4NCg0KPiAtLS0tLU9yaWdpbmFs
IE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTY290dCBXb29kIFttYWlsdG86b3NzQGJ1c2Vycm9yLm5l
dF0NCj4gU2VudDogMjAxNuW5tDTmnIg35pelIDY6MDENCj4gVG86IFpoaXFpYW5nIEhvdSA8emhp
cWlhbmcuaG91QG54cC5jb20+OyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZzsNCj4gYmVu
aEBrZXJuZWwuY3Jhc2hpbmcub3JnOyBwYXVsdXNAc2FtYmEub3JnOyBtcGVAZWxsZXJtYW4uaWQu
YXUNCj4gQ2M6IE1pbmdrYWkgSHUgPG1pbmdrYWkuaHVAbnhwLmNvbT4NCj4gU3ViamVjdDogUmU6
IFtQQVRDSF0gcG93ZXJwYy9jb25maWc6IERpc2FibGUgdGhlIDRLaUIgZXJhc2UgZ3JhbnVsYXJp
dHkgb2YgU1BJDQo+IGZsYXNoDQo+IA0KPiBPbiBXZWQsIDIwMTYtMDQtMDYgYXQgMTg6MTQgKzA4
MDAsIFpoaXFpYW5nIEhvdSB3cm90ZToNCj4gPiBGcm9tOiBIb3UgWmhpcWlhbmcgPFpoaXFpYW5n
LkhvdUBueHAuY29tPg0KPiA+DQo+ID4gRGlzYWJsZSB0aGUgc3Vic2VjdG9yICg0S2lCKSBlcmFz
ZSBncmFudWxhcml0eSB0byBzcGVlZCB1cCB0aGUgZXJhc2UNCj4gPiBvcGVyYXRpb24uDQo+ID4N
Cj4gPiBTaWduZWQtb2ZmLWJ5OiBIb3UgWmhpcWlhbmcgPFpoaXFpYW5nLkhvdUBueHAuY29tPg0K
PiA+IC0tLQ0KPiA+ICBhcmNoL3Bvd2VycGMvY29uZmlncy84NXh4LWh3LmNvbmZpZyB8IDEgKw0K
PiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKykNCj4gPg0KPiA+IGRpZmYgLS1naXQg
YS9hcmNoL3Bvd2VycGMvY29uZmlncy84NXh4LWh3LmNvbmZpZw0KPiA+IGIvYXJjaC9wb3dlcnBj
L2NvbmZpZ3MvODV4eCAtaHcuY29uZmlnIGluZGV4IDUyOGZmMGUuLmEwZjRlNzAgMTAwNjQ0DQo+
ID4gLS0tIGEvYXJjaC9wb3dlcnBjL2NvbmZpZ3MvODV4eC1ody5jb25maWcNCj4gPiArKysgYi9h
cmNoL3Bvd2VycGMvY29uZmlncy84NXh4LWh3LmNvbmZpZw0KPiA+IEBAIC03Nyw2ICs3Nyw3IEBA
IENPTkZJR19NVERfUEhZU01BUF9PRj15DQo+IENPTkZJR19NVERfUEhZU01BUD15DQo+ID4gQ09O
RklHX01URF9QTEFUUkFNPXkgIENPTkZJR19NVERfU1BJX05PUj15DQo+ID4gKyMgQ09ORklHX01U
RF9TUElfTk9SX1VTRV80S19TRUNUT1JTIGlzIG5vdCBzZXQNCj4gPiAgQ09ORklHX05FVERFVklD
RVM9eQ0KPiA+ICBDT05GSUdfTlZSQU09eQ0KPiA+ICBDT05GSUdfUEFUQV9BTEk9eQ0KPiANCj4g
SXMgdGhlcmUgYSByZWFzb24gc3BlY2lmaWMgdG8gODV4eCB0byBoYXZlIGEgZGlmZmVyZW50IGRl
ZmF1bHQgdGhhbiBldmVyeSBvdGhlcg0KPiBwbGF0Zm9ybSBleGNlcHQgbHBjMTh4eD8gIFRoZSBk
ZXNjcmlwdGlvbiBvZiBNVERfU1BJX05PUl9VU0VfNEtfU0VDVE9SUw0KPiBhY2tub3dsZWRnZXMg
dGhhdCBlcmFzZSBzcGVlZCBpcyBhIHRyYWRlb2ZmLiAgV2h5IGlzIHRoYXQgY29uY2VybiBtb3Jl
DQo+IGNvbXBlbGxpbmcgb24gODV4eCB0aGFuIGVsc2V3aGVyZT8NCj4gDQoNCkkgZG9uJ3Qgd2Fu
dCB0byBzcGVjaWZ5IDg1eHgsIGJ1dCBjb25maWdzIG9mIGZzbC4gSSdtIHN0aWxsIGNvbmZ1c2lu
ZyAgYWJvdXQgc28gbWFueQ0KY29uZmlncy4gV2lsbCBhZGQgb3RoZXIgcGxhdGZvcm1zIGlmIG5l
Y2Vzc2FyeS4NCg0KRm9yIHRoaXMgcGF0Y2gsIGl0IHRha2VzIGFib3V0IDEzIG1pbnMgdG8gZXJh
c2UgNjRNaUIgYnkgc3Vic2VjdG9yIGVyYXNlIGNvbW1hbmQNCig0S2lCIHBlciB0aW1lKSwgYnV0
IHRha2VzIDIgbWlucyBieSBzZWN0b3IgZXJhc2UgY29tbWFuZCg2NEtpQiBwZXIgdGltZSkuIEl0
IGlzDQpjb25zcGljdW91cyBkZWNyZWFzZS4gV2h5IGl0IHVzZXMgdGhlIDRLaUIgZ3JhbnVsYXJp
dHkgYnkgZGVmYXVsdCwgd2hhdCdzIHRoZQ0KYmVuZWZpdD8NCg0KVGhhbmtzLA0KWmhpcWlhbmcN
Cg0K
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash
2016-04-07 3:17 ` Zhiqiang Hou
@ 2016-04-08 16:01 ` David Laight
2016-04-11 5:25 ` Zhiqiang Hou
2016-04-17 1:58 ` Scott Wood
1 sibling, 1 reply; 6+ messages in thread
From: David Laight @ 2016-04-08 16:01 UTC (permalink / raw)
To: 'Zhiqiang Hou', Scott Wood, linuxppc-dev@lists.ozlabs.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: Mingkai Hu
RnJvbTogWmhpcWlhbmcgSG91DQo+IFNlbnQ6IDA3IEFwcmlsIDIwMTYgMDQ6MTcNCi4uLg0KPiA+
IElzIHRoZXJlIGEgcmVhc29uIHNwZWNpZmljIHRvIDg1eHggdG8gaGF2ZSBhIGRpZmZlcmVudCBk
ZWZhdWx0IHRoYW4gZXZlcnkgb3RoZXINCj4gPiBwbGF0Zm9ybSBleGNlcHQgbHBjMTh4eD8gIFRo
ZSBkZXNjcmlwdGlvbiBvZiBNVERfU1BJX05PUl9VU0VfNEtfU0VDVE9SUw0KPiA+IGFja25vd2xl
ZGdlcyB0aGF0IGVyYXNlIHNwZWVkIGlzIGEgdHJhZGVvZmYuICBXaHkgaXMgdGhhdCBjb25jZXJu
IG1vcmUNCj4gPiBjb21wZWxsaW5nIG9uIDg1eHggdGhhbiBlbHNld2hlcmU/DQo+ID4NCj4gDQo+
IEkgZG9uJ3Qgd2FudCB0byBzcGVjaWZ5IDg1eHgsIGJ1dCBjb25maWdzIG9mIGZzbC4gSSdtIHN0
aWxsIGNvbmZ1c2luZyAgYWJvdXQgc28gbWFueQ0KPiBjb25maWdzLiBXaWxsIGFkZCBvdGhlciBw
bGF0Zm9ybXMgaWYgbmVjZXNzYXJ5Lg0KPiANCj4gRm9yIHRoaXMgcGF0Y2gsIGl0IHRha2VzIGFi
b3V0IDEzIG1pbnMgdG8gZXJhc2UgNjRNaUIgYnkgc3Vic2VjdG9yIGVyYXNlIGNvbW1hbmQNCj4g
KDRLaUIgcGVyIHRpbWUpLCBidXQgdGFrZXMgMiBtaW5zIGJ5IHNlY3RvciBlcmFzZSBjb21tYW5k
KDY0S2lCIHBlciB0aW1lKS4gSXQgaXMNCj4gY29uc3BpY3VvdXMgZGVjcmVhc2UuIFdoeSBpdCB1
c2VzIHRoZSA0S2lCIGdyYW51bGFyaXR5IGJ5IGRlZmF1bHQsIHdoYXQncyB0aGUNCj4gYmVuZWZp
dD8NCg0KU2hvdWxkIGl0IGJlIGRvaW5nIDY0SyBlcmFzZXMgZm9sbG93ZWQgYnkgMCB0byAxNSA0
SyBlcmFzZXMgZm9yIGFueSBmaW5hbCBmcmFnbWVudD8NCg0KCURhdmlkDQoNCg==
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash
2016-04-08 16:01 ` David Laight
@ 2016-04-11 5:25 ` Zhiqiang Hou
0 siblings, 0 replies; 6+ messages in thread
From: Zhiqiang Hou @ 2016-04-11 5:25 UTC (permalink / raw)
To: David Laight, Scott Wood, linuxppc-dev@lists.ozlabs.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au
Cc: Mingkai Hu
SGkgRGF2aWQsDQoNClRoYW5rcyBmb3IgeW91ciBjb21tZW50cy4NCg0KPiAtLS0tLU9yaWdpbmFs
IE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBEYXZpZCBMYWlnaHQgW21haWx0bzpEYXZpZC5MYWlnaHRA
QUNVTEFCLkNPTV0NCj4gU2VudDogMjAxNuW5tDTmnIg55pelIDA6MDENCj4gVG86IFpoaXFpYW5n
IEhvdSA8emhpcWlhbmcuaG91QG54cC5jb20+OyBTY290dCBXb29kIDxvc3NAYnVzZXJyb3IubmV0
PjsNCj4gbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGJlbmhAa2VybmVsLmNyYXNoaW5n
Lm9yZzsgcGF1bHVzQHNhbWJhLm9yZzsNCj4gbXBlQGVsbGVybWFuLmlkLmF1DQo+IENjOiBNaW5n
a2FpIEh1IDxtaW5na2FpLmh1QG54cC5jb20+DQo+IFN1YmplY3Q6IFJFOiBbUEFUQ0hdIHBvd2Vy
cGMvY29uZmlnOiBEaXNhYmxlIHRoZSA0S2lCIGVyYXNlIGdyYW51bGFyaXR5IG9mIFNQSQ0KPiBm
bGFzaA0KPiANCj4gRnJvbTogWmhpcWlhbmcgSG91DQo+ID4gU2VudDogMDcgQXByaWwgMjAxNiAw
NDoxNw0KPiAuLi4NCj4gPiA+IElzIHRoZXJlIGEgcmVhc29uIHNwZWNpZmljIHRvIDg1eHggdG8g
aGF2ZSBhIGRpZmZlcmVudCBkZWZhdWx0IHRoYW4NCj4gPiA+IGV2ZXJ5IG90aGVyIHBsYXRmb3Jt
IGV4Y2VwdCBscGMxOHh4PyAgVGhlIGRlc2NyaXB0aW9uIG9mDQo+ID4gPiBNVERfU1BJX05PUl9V
U0VfNEtfU0VDVE9SUyBhY2tub3dsZWRnZXMgdGhhdCBlcmFzZSBzcGVlZCBpcyBhDQo+ID4gPiB0
cmFkZW9mZi4gIFdoeSBpcyB0aGF0IGNvbmNlcm4gbW9yZSBjb21wZWxsaW5nIG9uIDg1eHggdGhh
biBlbHNld2hlcmU/DQo+ID4gPg0KPiA+DQo+ID4gSSBkb24ndCB3YW50IHRvIHNwZWNpZnkgODV4
eCwgYnV0IGNvbmZpZ3Mgb2YgZnNsLiBJJ20gc3RpbGwgY29uZnVzaW5nDQo+ID4gYWJvdXQgc28g
bWFueSBjb25maWdzLiBXaWxsIGFkZCBvdGhlciBwbGF0Zm9ybXMgaWYgbmVjZXNzYXJ5Lg0KPiA+
DQo+ID4gRm9yIHRoaXMgcGF0Y2gsIGl0IHRha2VzIGFib3V0IDEzIG1pbnMgdG8gZXJhc2UgNjRN
aUIgYnkgc3Vic2VjdG9yDQo+ID4gZXJhc2UgY29tbWFuZCAoNEtpQiBwZXIgdGltZSksIGJ1dCB0
YWtlcyAyIG1pbnMgYnkgc2VjdG9yIGVyYXNlDQo+ID4gY29tbWFuZCg2NEtpQiBwZXIgdGltZSku
IEl0IGlzIGNvbnNwaWN1b3VzIGRlY3JlYXNlLiBXaHkgaXQgdXNlcyB0aGUNCj4gPiA0S2lCIGdy
YW51bGFyaXR5IGJ5IGRlZmF1bHQsIHdoYXQncyB0aGUgYmVuZWZpdD8NCj4gDQo+IFNob3VsZCBp
dCBiZSBkb2luZyA2NEsgZXJhc2VzIGZvbGxvd2VkIGJ5IDAgdG8gMTUgNEsgZXJhc2VzIGZvciBh
bnkgZmluYWwgZnJhZ21lbnQ/DQoNCldoZW4gd2lsbCB0aGlzIHNpdHVhdGlvbiBjb21lIHVwPw0K
DQpUaGFua3MsDQpaaGlxaWFuZw0KDQo=
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash
2016-04-07 3:17 ` Zhiqiang Hou
2016-04-08 16:01 ` David Laight
@ 2016-04-17 1:58 ` Scott Wood
1 sibling, 0 replies; 6+ messages in thread
From: Scott Wood @ 2016-04-17 1:58 UTC (permalink / raw)
To: Zhiqiang Hou, linuxppc-dev@lists.ozlabs.org,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
linux-mtd
Cc: Mingkai Hu
On Thu, 2016-04-07 at 03:17 +0000, Zhiqiang Hou wrote:
> Hi Scott,
>
> Thanks for your comments.
>
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: 2016年4月7日 6:01
> > To: Zhiqiang Hou <zhiqiang.hou@nxp.com>; linuxppc-dev@lists.ozlabs.org;
> > benh@kernel.crashing.org; paulus@samba.org; mpe@ellerman.id.au
> > Cc: Mingkai Hu <mingkai.hu@nxp.com>
> > Subject: Re: [PATCH] powerpc/config: Disable the 4KiB erase granularity of
> > SPI
> > flash
> >
> > On Wed, 2016-04-06 at 18:14 +0800, Zhiqiang Hou wrote:
> > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > >
> > > Disable the subsector (4KiB) erase granularity to speed up the erase
> > > operation.
> > >
> > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > > ---
> > > arch/powerpc/configs/85xx-hw.config | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/arch/powerpc/configs/85xx-hw.config
> > > b/arch/powerpc/configs/85xx -hw.config index 528ff0e..a0f4e70 100644
> > > --- a/arch/powerpc/configs/85xx-hw.config
> > > +++ b/arch/powerpc/configs/85xx-hw.config
> > > @@ -77,6 +77,7 @@ CONFIG_MTD_PHYSMAP_OF=y
> > CONFIG_MTD_PHYSMAP=y
> > > CONFIG_MTD_PLATRAM=y CONFIG_MTD_SPI_NOR=y
> > > +# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
> > > CONFIG_NETDEVICES=y
> > > CONFIG_NVRAM=y
> > > CONFIG_PATA_ALI=y
> >
> > Is there a reason specific to 85xx to have a different default than every
> > other
> > platform except lpc18xx? The description of MTD_SPI_NOR_USE_4K_SECTORS
> > acknowledges that erase speed is a tradeoff. Why is that concern more
> > compelling on 85xx than elsewhere?
> >
>
> I don't want to specify 85xx, but configs of fsl.
That doesn't change my question (but it does mean you put it in the wrong
file).
> For this patch, it takes about 13 mins to erase 64MiB by subsector erase
> command
> (4KiB per time), but takes 2 mins by sector erase command(64KiB per time).
> It is
> conspicuous decrease. Why it uses the 4KiB granularity by default, what's
> the
> benefit?
Again, the help text for this item says that it slows writes down, yet it's
still on by default. Presumably there are other benefits that are deemed to
outweigh the slower erase.
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-17 1:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-06 10:14 [PATCH] powerpc/config: Disable the 4KiB erase granularity of SPI flash Zhiqiang Hou
2016-04-06 22:01 ` Scott Wood
2016-04-07 3:17 ` Zhiqiang Hou
2016-04-08 16:01 ` David Laight
2016-04-11 5:25 ` Zhiqiang Hou
2016-04-17 1:58 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).