* [PATCH] cxl: static-ify variables to fix sparse warnings
@ 2016-04-18 5:03 Andrew Donnellan
2016-04-18 8:32 ` Frederic Barrat
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Andrew Donnellan @ 2016-04-18 5:03 UTC (permalink / raw)
To: linuxppc-dev; +Cc: imunsie, clombard, fbarrat
Make a couple more variables static. Found by sparse.
Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
---
drivers/misc/cxl/flash.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
index 68dd0b7..c63d61e 100644
--- a/drivers/misc/cxl/flash.c
+++ b/drivers/misc/cxl/flash.c
@@ -24,8 +24,8 @@ struct ai_header {
};
static struct semaphore sem;
-unsigned long *buffer[CXL_AI_MAX_ENTRIES];
-struct sg_list *le;
+static unsigned long *buffer[CXL_AI_MAX_ENTRIES];
+static struct sg_list *le;
static u64 continue_token;
static unsigned int transfer;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] cxl: static-ify variables to fix sparse warnings
2016-04-18 5:03 [PATCH] cxl: static-ify variables to fix sparse warnings Andrew Donnellan
@ 2016-04-18 8:32 ` Frederic Barrat
2016-04-18 15:37 ` Matthew R. Ochs
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Frederic Barrat @ 2016-04-18 8:32 UTC (permalink / raw)
To: Andrew Donnellan, linuxppc-dev; +Cc: imunsie, clombard
Thanks Andrew!
Reviewed-by: fbarrat@linux.vnet.ibm.com
Fred
Le 18/04/2016 07:03, Andrew Donnellan a écrit :
> Make a couple more variables static. Found by sparse.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
> drivers/misc/cxl/flash.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
> index 68dd0b7..c63d61e 100644
> --- a/drivers/misc/cxl/flash.c
> +++ b/drivers/misc/cxl/flash.c
> @@ -24,8 +24,8 @@ struct ai_header {
> };
>
> static struct semaphore sem;
> -unsigned long *buffer[CXL_AI_MAX_ENTRIES];
> -struct sg_list *le;
> +static unsigned long *buffer[CXL_AI_MAX_ENTRIES];
> +static struct sg_list *le;
> static u64 continue_token;
> static unsigned int transfer;
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] cxl: static-ify variables to fix sparse warnings
2016-04-18 5:03 [PATCH] cxl: static-ify variables to fix sparse warnings Andrew Donnellan
2016-04-18 8:32 ` Frederic Barrat
@ 2016-04-18 15:37 ` Matthew R. Ochs
2016-04-19 6:16 ` Ian Munsie
2016-06-21 0:40 ` Michael Ellerman
3 siblings, 0 replies; 5+ messages in thread
From: Matthew R. Ochs @ 2016-04-18 15:37 UTC (permalink / raw)
To: Andrew Donnellan; +Cc: linuxppc-dev, imunsie, fbarrat, clombard
Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] cxl: static-ify variables to fix sparse warnings
2016-04-18 5:03 [PATCH] cxl: static-ify variables to fix sparse warnings Andrew Donnellan
2016-04-18 8:32 ` Frederic Barrat
2016-04-18 15:37 ` Matthew R. Ochs
@ 2016-04-19 6:16 ` Ian Munsie
2016-06-21 0:40 ` Michael Ellerman
3 siblings, 0 replies; 5+ messages in thread
From: Ian Munsie @ 2016-04-19 6:16 UTC (permalink / raw)
To: andrew.donnellan; +Cc: linuxppc-dev, clombard, fbarrat
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: cxl: static-ify variables to fix sparse warnings
2016-04-18 5:03 [PATCH] cxl: static-ify variables to fix sparse warnings Andrew Donnellan
` (2 preceding siblings ...)
2016-04-19 6:16 ` Ian Munsie
@ 2016-06-21 0:40 ` Michael Ellerman
3 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2016-06-21 0:40 UTC (permalink / raw)
To: Andrew Donnellan, linuxppc-dev; +Cc: imunsie, fbarrat, clombard
On Mon, 2016-18-04 at 05:03:50 UTC, Andrew Donnellan wrote:
> Make a couple more variables static. Found by sparse.
>
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> Reviewed-by: fbarrat@linux.vnet.ibm.com
> Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
> Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/64417a398973d964139306c0b1
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-21 0:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-18 5:03 [PATCH] cxl: static-ify variables to fix sparse warnings Andrew Donnellan
2016-04-18 8:32 ` Frederic Barrat
2016-04-18 15:37 ` Matthew R. Ochs
2016-04-19 6:16 ` Ian Munsie
2016-06-21 0:40 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).