From: Michael Ellerman <mpe@ellerman.id.au>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH kernel] powerpc/powernv: Fix debug macro
Date: Fri, 29 Apr 2016 15:29:40 +1000 [thread overview]
Message-ID: <1461907780.3865.2.camel@ellerman.id.au> (raw)
In-Reply-To: <1461905766-22558-1-git-send-email-aik@ozlabs.ru>
On Fri, 2016-04-29 at 14:56 +1000, Alexey Kardashevskiy wrote:
> When cfg_dbg() is enabled (i.e. mapped to printk()), gcc produces
> errors as the __func__ parameter is missing (pnv_pci_cfg_read() has one);
> this adds the missing parameter.
Thanks.
But the whole file should just be converted to use pr_devel(), which is an
existing well known macro and will catch this for you.
cheers
prev parent reply other threads:[~2016-04-29 5:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 4:56 [PATCH kernel] powerpc/powernv: Fix debug macro Alexey Kardashevskiy
2016-04-29 5:07 ` Andrew Donnellan
2016-04-29 5:29 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461907780.3865.2.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=aik@ozlabs.ru \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox