* [PATCH] selftests/powerpc: Fix subpage_prot test to return !0 on failure @ 2016-05-02 4:54 Michael Ellerman 2016-05-02 11:17 ` Aneesh Kumar K.V 2016-05-04 22:40 ` Michael Ellerman 0 siblings, 2 replies; 4+ messages in thread From: Michael Ellerman @ 2016-05-02 4:54 UTC (permalink / raw) To: linuxppc-dev; +Cc: aneesh.kumar It's helpful for automated testing if the test returns error codes back to the calling program. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> --- tools/testing/selftests/powerpc/mm/subpage_prot.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/powerpc/mm/subpage_prot.c b/tools/testing/selftests/powerpc/mm/subpage_prot.c index 440180ff8089..7ccdc96b977d 100644 --- a/tools/testing/selftests/powerpc/mm/subpage_prot.c +++ b/tools/testing/selftests/powerpc/mm/subpage_prot.c @@ -207,14 +207,16 @@ int test_file(void) int main(int argc, char *argv[]) { - test_harness(test_anon, "subpage_prot_anon"); + int rc; + + rc = test_harness(test_anon, "subpage_prot_anon"); + if (rc) + return rc; if (argc > 1) file_name = argv[1]; else file_name = "tempfile"; - test_harness(test_file, "subpage_prot_file"); - - return 0; + return test_harness(test_file, "subpage_prot_file"); } -- 2.5.0 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/powerpc: Fix subpage_prot test to return !0 on failure 2016-05-02 4:54 [PATCH] selftests/powerpc: Fix subpage_prot test to return !0 on failure Michael Ellerman @ 2016-05-02 11:17 ` Aneesh Kumar K.V 2016-05-03 5:56 ` Aneesh Kumar K.V 2016-05-04 22:40 ` Michael Ellerman 1 sibling, 1 reply; 4+ messages in thread From: Aneesh Kumar K.V @ 2016-05-02 11:17 UTC (permalink / raw) To: Michael Ellerman, linuxppc-dev Michael Ellerman <mpe@ellerman.id.au> writes: > It's helpful for automated testing if the test returns error codes back > to the calling program. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > --- > tools/testing/selftests/powerpc/mm/subpage_prot.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/powerpc/mm/subpage_prot.c b/tools/testing/selftests/powerpc/mm/subpage_prot.c > index 440180ff8089..7ccdc96b977d 100644 > --- a/tools/testing/selftests/powerpc/mm/subpage_prot.c > +++ b/tools/testing/selftests/powerpc/mm/subpage_prot.c > @@ -207,14 +207,16 @@ int test_file(void) > > int main(int argc, char *argv[]) > { > - test_harness(test_anon, "subpage_prot_anon"); > + int rc; > + > + rc = test_harness(test_anon, "subpage_prot_anon"); > + if (rc) > + return rc; > > if (argc > 1) > file_name = argv[1]; > else > file_name = "tempfile"; > > - test_harness(test_file, "subpage_prot_file"); > - > - return 0; > + return test_harness(test_file, "subpage_prot_file"); > } > -- > 2.5.0 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] selftests/powerpc: Fix subpage_prot test to return !0 on failure 2016-05-02 11:17 ` Aneesh Kumar K.V @ 2016-05-03 5:56 ` Aneesh Kumar K.V 0 siblings, 0 replies; 4+ messages in thread From: Aneesh Kumar K.V @ 2016-05-03 5:56 UTC (permalink / raw) To: Michael Ellerman, linuxppc-dev "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> writes: > Michael Ellerman <mpe@ellerman.id.au> writes: > >> It's helpful for automated testing if the test returns error codes back >> to the calling program. >> >> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > > > Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> > >> --- >> tools/testing/selftests/powerpc/mm/subpage_prot.c | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/tools/testing/selftests/powerpc/mm/subpage_prot.c b/tools/testing/selftests/powerpc/mm/subpage_prot.c >> index 440180ff8089..7ccdc96b977d 100644 >> --- a/tools/testing/selftests/powerpc/mm/subpage_prot.c >> +++ b/tools/testing/selftests/powerpc/mm/subpage_prot.c >> @@ -207,14 +207,16 @@ int test_file(void) >> >> int main(int argc, char *argv[]) >> { >> - test_harness(test_anon, "subpage_prot_anon"); >> + int rc; >> + >> + rc = test_harness(test_anon, "subpage_prot_anon"); >> + if (rc) >> + return rc; >> >> if (argc > 1) >> file_name = argv[1]; >> else >> file_name = "tempfile"; >> >> - test_harness(test_file, "subpage_prot_file"); >> - >> - return 0; >> + return test_harness(test_file, "subpage_prot_file"); >> } >> -- >> 2.5.0 While doing this fix the error print ? 520175565: (4520111850): Failed at 0x0x3fffad4b0000 (p=13,sp=0,w=0), want=fault, got=pass ! diff --git a/tools/testing/selftests/powerpc/mm/subpage_prot.c b/tools/testing/selftests/powerpc/mm/subpage_prot.c index 440180ff8089..5929866aa444 100644 --- a/tools/testing/selftests/powerpc/mm/subpage_prot.c +++ b/tools/testing/selftests/powerpc/mm/subpage_prot.c @@ -73,7 +73,7 @@ static inline void check_faulted(void *addr, long page, long subpage, int write) want_fault |= (subpage == ((page + 1) % 16)); if (faulted != want_fault) { - printf("Failed at 0x%p (p=%ld,sp=%ld,w=%d), want=%s, got=%s !\n", + printf("Failed at %p (p=%ld,sp=%ld,w=%d), want=%s, got=%s !\n", addr, page, subpage, write, want_fault ? "fault" : "pass", faulted ? "fault" : "pass"); ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: selftests/powerpc: Fix subpage_prot test to return !0 on failure 2016-05-02 4:54 [PATCH] selftests/powerpc: Fix subpage_prot test to return !0 on failure Michael Ellerman 2016-05-02 11:17 ` Aneesh Kumar K.V @ 2016-05-04 22:40 ` Michael Ellerman 1 sibling, 0 replies; 4+ messages in thread From: Michael Ellerman @ 2016-05-04 22:40 UTC (permalink / raw) To: Michael Ellerman, linuxppc-dev; +Cc: aneesh.kumar On Mon, 2016-02-05 at 04:54:29 UTC, Michael Ellerman wrote: > It's helpful for automated testing if the test returns error codes back > to the calling program. > > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com> Applied to powerpc next. https://git.kernel.org/powerpc/c/3a19e500d8cdb39ef9ce128933 cheers ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-05-04 22:40 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-05-02 4:54 [PATCH] selftests/powerpc: Fix subpage_prot test to return !0 on failure Michael Ellerman 2016-05-02 11:17 ` Aneesh Kumar K.V 2016-05-03 5:56 ` Aneesh Kumar K.V 2016-05-04 22:40 ` Michael Ellerman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).