* [PATCH] cxl: Remove duplicate #defines
@ 2016-05-04 4:48 Ian Munsie
2016-05-04 5:15 ` Andrew Donnellan
2016-05-10 21:48 ` Michael Ellerman
0 siblings, 2 replies; 3+ messages in thread
From: Ian Munsie @ 2016-05-04 4:48 UTC (permalink / raw)
To: Michael Ellerman, mikey, linuxppc-dev; +Cc: Ian Munsie
From: Ian Munsie <imunsie@au1.ibm.com>
These defines are not used, but other equivalent definitions
(CXL_SPA_SW_CMD_*) are used. Remove the unused defines.
Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
---
drivers/misc/cxl/cxl.h | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/misc/cxl/cxl.h b/drivers/misc/cxl/cxl.h
index dfdbfb0..2823fb3 100644
--- a/drivers/misc/cxl/cxl.h
+++ b/drivers/misc/cxl/cxl.h
@@ -178,15 +178,6 @@ static const cxl_p2n_reg_t CXL_PSL_WED_An = {0x0A0};
#define CXL_PSL_SR_An_MP (1ull << (63-62)) /* Master Process */
#define CXL_PSL_SR_An_LE (1ull << (63-63)) /* Little Endian */
-/****** CXL_PSL_LLCMD_An ****************************************************/
-#define CXL_LLCMD_TERMINATE 0x0001000000000000ULL
-#define CXL_LLCMD_REMOVE 0x0002000000000000ULL
-#define CXL_LLCMD_SUSPEND 0x0003000000000000ULL
-#define CXL_LLCMD_RESUME 0x0004000000000000ULL
-#define CXL_LLCMD_ADD 0x0005000000000000ULL
-#define CXL_LLCMD_UPDATE 0x0006000000000000ULL
-#define CXL_LLCMD_HANDLE_MASK 0x000000000000ffffULL
-
/****** CXL_PSL_ID_An ****************************************************/
#define CXL_PSL_ID_An_F (1ull << (63-31))
#define CXL_PSL_ID_An_L (1ull << (63-30))
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cxl: Remove duplicate #defines
2016-05-04 4:48 [PATCH] cxl: Remove duplicate #defines Ian Munsie
@ 2016-05-04 5:15 ` Andrew Donnellan
2016-05-10 21:48 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Donnellan @ 2016-05-04 5:15 UTC (permalink / raw)
To: Ian Munsie, Michael Ellerman, mikey, linuxppc-dev
On 04/05/16 14:48, Ian Munsie wrote:
> From: Ian Munsie <imunsie@au1.ibm.com>
>
> These defines are not used, but other equivalent definitions
> (CXL_SPA_SW_CMD_*) are used. Remove the unused defines.
>
> Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
They definitely look unused.
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com IBM Australia Limited
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cxl: Remove duplicate #defines
2016-05-04 4:48 [PATCH] cxl: Remove duplicate #defines Ian Munsie
2016-05-04 5:15 ` Andrew Donnellan
@ 2016-05-10 21:48 ` Michael Ellerman
1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2016-05-10 21:48 UTC (permalink / raw)
To: Ian Munsie, mikey, linuxppc-dev; +Cc: Ian Munsie
On Wed, 2016-04-05 at 04:48:32 UTC, Ian Munsie wrote:
> From: Ian Munsie <imunsie@au1.ibm.com>
>
> These defines are not used, but other equivalent definitions
> (CXL_SPA_SW_CMD_*) are used. Remove the unused defines.
>
> Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/29659b682c47986d7d4e6206d9
cheers
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-10 21:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-04 4:48 [PATCH] cxl: Remove duplicate #defines Ian Munsie
2016-05-04 5:15 ` Andrew Donnellan
2016-05-10 21:48 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).