linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Russell Currey <ruscur@russell.cc>,
	"Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: linuxppc-dev@lists.ozlabs.org,
	Andrea Gelmini <andrea.gelmini@gelma.net>,
	 trivial@kernel.org, paulus@samba.org
Subject: Re: [PATCH 0213/1529] Fix typo
Date: Tue, 24 May 2016 13:11:01 +1000	[thread overview]
Message-ID: <1464059461.32034.1.camel@ellerman.id.au> (raw)
In-Reply-To: <1464048297.2237.1.camel@russell.cc>

On Tue, 2016-05-24 at 10:04 +1000, Russell Currey wrote:
> On Mon, 2016-05-23 at 03:12 -0400, Robert P. J. Day wrote:
> > On Mon, 23 May 2016, Russell Currey wrote:
> > > On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
> > > > Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> > > > ---
> > > 
> > > This entire comment needs to be rewritten as it's incredibly confusing, but
> > > alas
> > > 
> > > Acked-by: Russell Currey <ruscur@russell.cc>
> > > 
> > > >  arch/powerpc/include/asm/eeh.h | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/arch/powerpc/include/asm/eeh.h
> > > > b/arch/powerpc/include/asm/eeh.h
> > > > index fb9f376..7d34f3d 100644
> > > > --- a/arch/powerpc/include/asm/eeh.h
> > > > +++ b/arch/powerpc/include/asm/eeh.h
> > > > @@ -57,7 +57,7 @@ struct pci_dn;
> > > >  /*
> > > >   * The struct is used to trace PE related EEH functionality.
> > > >   * In theory, there will have one instance of the struct to
> > 
> >   "there will have one instance"?
> 
> See "This entire comment needs to be rewritten as it's incredibly confusing" :)
> 
> EEH documentation, both in source and in Documentation/powerpc/, is very much in
> need of updates and reworks.  I'm working on it.

Thanks. I'll wait for that, I'm not interested in merging a single byte typo
fix to an otherwise badly worded comment.

cheers

      reply	other threads:[~2016-05-24  3:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-21 12:03 [PATCH 0213/1529] Fix typo Andrea Gelmini
2016-05-23  1:30 ` Russell Currey
2016-05-23  7:12   ` Robert P. J. Day
2016-05-24  0:04     ` Russell Currey
2016-05-24  3:11       ` Michael Ellerman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464059461.32034.1.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=andrea.gelmini@gelma.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=paulus@samba.org \
    --cc=rpjday@crashcourse.ca \
    --cc=ruscur@russell.cc \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).