* [PATCH 0213/1529] Fix typo
@ 2016-05-21 12:03 Andrea Gelmini
2016-05-23 1:30 ` Russell Currey
0 siblings, 1 reply; 5+ messages in thread
From: Andrea Gelmini @ 2016-05-21 12:03 UTC (permalink / raw)
To: andrea.gelmini; +Cc: trivial, ruscur, benh, paulus, mpe, linuxppc-dev
Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
arch/powerpc/include/asm/eeh.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
index fb9f376..7d34f3d 100644
--- a/arch/powerpc/include/asm/eeh.h
+++ b/arch/powerpc/include/asm/eeh.h
@@ -57,7 +57,7 @@ struct pci_dn;
/*
* The struct is used to trace PE related EEH functionality.
* In theory, there will have one instance of the struct to
- * be created against particular PE. In nature, PEs corelate
+ * be created against particular PE. In nature, PEs correlate
* to each other. the struct has to reflect that hierarchy in
* order to easily pick up those affected PEs when one particular
* PE has EEH errors.
--
2.8.2.534.g1f66975
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 0213/1529] Fix typo
2016-05-21 12:03 [PATCH 0213/1529] Fix typo Andrea Gelmini
@ 2016-05-23 1:30 ` Russell Currey
2016-05-23 7:12 ` Robert P. J. Day
0 siblings, 1 reply; 5+ messages in thread
From: Russell Currey @ 2016-05-23 1:30 UTC (permalink / raw)
To: Andrea Gelmini; +Cc: trivial, benh, paulus, mpe, linuxppc-dev
On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
This entire comment needs to be rewritten as it's incredibly confusing, but alas
Acked-by: Russell Currey <ruscur@russell.cc>
> arch/powerpc/include/asm/eeh.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
> index fb9f376..7d34f3d 100644
> --- a/arch/powerpc/include/asm/eeh.h
> +++ b/arch/powerpc/include/asm/eeh.h
> @@ -57,7 +57,7 @@ struct pci_dn;
> /*
> * The struct is used to trace PE related EEH functionality.
> * In theory, there will have one instance of the struct to
> - * be created against particular PE. In nature, PEs corelate
> + * be created against particular PE. In nature, PEs correlate
> * to each other. the struct has to reflect that hierarchy in
> * order to easily pick up those affected PEs when one particular
> * PE has EEH errors.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0213/1529] Fix typo
2016-05-23 1:30 ` Russell Currey
@ 2016-05-23 7:12 ` Robert P. J. Day
2016-05-24 0:04 ` Russell Currey
0 siblings, 1 reply; 5+ messages in thread
From: Robert P. J. Day @ 2016-05-23 7:12 UTC (permalink / raw)
To: Russell Currey; +Cc: Andrea Gelmini, trivial, linuxppc-dev, paulus
[-- Attachment #1: Type: text/plain, Size: 1242 bytes --]
On Mon, 23 May 2016, Russell Currey wrote:
> On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
> > Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> > ---
>
> This entire comment needs to be rewritten as it's incredibly confusing, but alas
>
> Acked-by: Russell Currey <ruscur@russell.cc>
>
> > arch/powerpc/include/asm/eeh.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h
> > index fb9f376..7d34f3d 100644
> > --- a/arch/powerpc/include/asm/eeh.h
> > +++ b/arch/powerpc/include/asm/eeh.h
> > @@ -57,7 +57,7 @@ struct pci_dn;
> > /*
> > * The struct is used to trace PE related EEH functionality.
> > * In theory, there will have one instance of the struct to
"there will have one instance"?
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0213/1529] Fix typo
2016-05-23 7:12 ` Robert P. J. Day
@ 2016-05-24 0:04 ` Russell Currey
2016-05-24 3:11 ` Michael Ellerman
0 siblings, 1 reply; 5+ messages in thread
From: Russell Currey @ 2016-05-24 0:04 UTC (permalink / raw)
To: Robert P. J. Day; +Cc: Andrea Gelmini, trivial, linuxppc-dev, paulus
On Mon, 2016-05-23 at 03:12 -0400, Robert P. J. Day wrote:
> On Mon, 23 May 2016, Russell Currey wrote:
>
> > On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
> > > Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> > > ---
> >
> > This entire comment needs to be rewritten as it's incredibly confusing, but
> > alas
> >
> > Acked-by: Russell Currey <ruscur@russell.cc>
> >
> > > arch/powerpc/include/asm/eeh.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/powerpc/include/asm/eeh.h
> > > b/arch/powerpc/include/asm/eeh.h
> > > index fb9f376..7d34f3d 100644
> > > --- a/arch/powerpc/include/asm/eeh.h
> > > +++ b/arch/powerpc/include/asm/eeh.h
> > > @@ -57,7 +57,7 @@ struct pci_dn;
> > > /*
> > > * The struct is used to trace PE related EEH functionality.
> > > * In theory, there will have one instance of the struct to
>
> "there will have one instance"?
See "This entire comment needs to be rewritten as it's incredibly confusing" :)
EEH documentation, both in source and in Documentation/powerpc/, is very much in
need of updates and reworks. I'm working on it.
- Russell
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0213/1529] Fix typo
2016-05-24 0:04 ` Russell Currey
@ 2016-05-24 3:11 ` Michael Ellerman
0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2016-05-24 3:11 UTC (permalink / raw)
To: Russell Currey, Robert P. J. Day
Cc: linuxppc-dev, Andrea Gelmini, trivial, paulus
On Tue, 2016-05-24 at 10:04 +1000, Russell Currey wrote:
> On Mon, 2016-05-23 at 03:12 -0400, Robert P. J. Day wrote:
> > On Mon, 23 May 2016, Russell Currey wrote:
> > > On Sat, 2016-05-21 at 14:03 +0200, Andrea Gelmini wrote:
> > > > Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> > > > ---
> > >
> > > This entire comment needs to be rewritten as it's incredibly confusing, but
> > > alas
> > >
> > > Acked-by: Russell Currey <ruscur@russell.cc>
> > >
> > > > arch/powerpc/include/asm/eeh.h | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/powerpc/include/asm/eeh.h
> > > > b/arch/powerpc/include/asm/eeh.h
> > > > index fb9f376..7d34f3d 100644
> > > > --- a/arch/powerpc/include/asm/eeh.h
> > > > +++ b/arch/powerpc/include/asm/eeh.h
> > > > @@ -57,7 +57,7 @@ struct pci_dn;
> > > > /*
> > > > * The struct is used to trace PE related EEH functionality.
> > > > * In theory, there will have one instance of the struct to
> >
> > "there will have one instance"?
>
> See "This entire comment needs to be rewritten as it's incredibly confusing" :)
>
> EEH documentation, both in source and in Documentation/powerpc/, is very much in
> need of updates and reworks. I'm working on it.
Thanks. I'll wait for that, I'm not interested in merging a single byte typo
fix to an otherwise badly worded comment.
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-05-24 3:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-21 12:03 [PATCH 0213/1529] Fix typo Andrea Gelmini
2016-05-23 1:30 ` Russell Currey
2016-05-23 7:12 ` Robert P. J. Day
2016-05-24 0:04 ` Russell Currey
2016-05-24 3:11 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).