From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Balbir Singh <bsingharora@gmail.com>,
paulus@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm: Use jump label to speed up radix_enabled check
Date: Fri, 10 Jun 2016 15:46:35 +1000 [thread overview]
Message-ID: <1465537595.2948.52.camel@kernel.crashing.org> (raw)
In-Reply-To: <1465532189.26682.9.camel@ellerman.id.au>
On Fri, 2016-06-10 at 14:16 +1000, Michael Ellerman wrote:
>
> It depends what that function does. It might work now, but it could break later
> when someone changes the jump label code, and it might work on some platforms
> but not others.
>
> That is *really* early. We haven't looked at the device tree yet, we haven't
> even enabled early debug.
>
> So I'd rather we did it later, but that has other issues I guess.
Yes it's too early. We may still change some of the CPU/MMU feature
values at that point.
Cheers,
Ben.
prev parent reply other threads:[~2016-06-10 5:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 16:24 [PATCH] powerpc/mm: Use jump label to speed up radix_enabled check Aneesh Kumar K.V
2016-04-26 21:05 ` Benjamin Herrenschmidt
2016-04-26 22:16 ` Balbir Singh
2016-04-26 23:05 ` Benjamin Herrenschmidt
2016-04-27 1:00 ` Balbir Singh
2016-04-27 1:46 ` Benjamin Herrenschmidt
2016-04-27 7:00 ` Aneesh Kumar K.V
2016-04-27 9:30 ` Aneesh Kumar K.V
2016-06-09 4:12 ` Benjamin Herrenschmidt
2016-06-09 6:00 ` Aneesh Kumar K.V
2016-06-09 15:58 ` Aneesh Kumar K.V
2016-06-10 4:16 ` Michael Ellerman
2016-06-10 5:46 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465537595.2948.52.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bsingharora@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).