linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Denis Kirjanov <kda@linux-powerpc.org>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: unrecoverable exception on G5 with CONFIG_PPC_EARLY_DEBUG enabled
Date: Thu, 16 Jun 2016 22:07:10 +1000	[thread overview]
Message-ID: <1466078830.19127.0.camel@ellerman.id.au> (raw)
In-Reply-To: <CAOJe8K1bBf-J6ZJq+VfVv+CVcwGyff32beGL4kXaZBr5ZL9hmw@mail.gmail.com>

On Thu, 2016-06-16 at 11:12 +0300, Denis Kirjanov wrote:
> On 6/6/16, Michael Ellerman <mpe@ellerman.id.au> wrote:
> > On Mon, 2016-06-06 at 10:52 +0300, Denis Kirjanov wrote:
> > > I haven't bisected this yet. Photo attached.
> > 
> > A bisect would be awesome.
> 
> Ok, the issue was introduced by the commit
> caca285e5ab4a7a19fede51688106ceed6fc45dd (powerpc/mm/radix: Use
> STD_MMU_64 to properly isolate hash related code) and 970mp dies on
> the following condition:

> +BEGIN_MMU_FTR_SECTION
>         bl      slb_allocate_realmode
> -
> +END_MMU_FTR_SECTION_IFCLR(MMU_FTR_RADIX)

Thanks.

How did you work that out?

That FTR section says to call slb_allocate_realmode() when MMU_FTR_RADIX is
clear (ie. zero). That should always be the case on your machine, unless you've
plugged a Power9 into your G5 ;)

> In my config I've enabled radix MMU lookup but in my understanding
> only recent IBM  machines support this feature and we have to call SLB
> entry through slb_allocate_realmode on HPTE machine?

That's right, and that's what the code should be doing.

My G5 is booting OK:

michael@cogito:~$ uname -a
Linux cogito 4.7.0-rc3-gdb06d75 #1 SMP Thu Jun 16 05:16:31 AEST 2016 ppc64 GNU/Linux

michael@cogito:~$ cat /proc/cpuinfo 
processor	: 0
cpu		: PPC970FX, altivec supported
clock		: 1599.999000MHz
revision	: 3.0 (pvr 003c 0300)

timebase	: 33333333
platform	: PowerMac
model		: PowerMac8,1
machine		: PowerMac8,1
motherboard	: PowerMac8,1 MacRISC4 Power Macintosh 
detected as	: 338 (iMac G5)
pmac flags	: 00000000
L2 cache	: 512K unified
pmac-generation	: NewWorld

michael@cogito:~$ zgrep RADIX /proc/config.gz 
CONFIG_PPC_RADIX_MMU=y

michael@cogito:~$ dmesg|grep _features
[    0.000000] cpu_features      = 0x0804806318100448
[    0.000000] cpu_user_features = 0xdc080000 0x00000000
[    0.000000] mmu_features      = 0x0c000001
[    0.000000] firmware_features = 0x0000000000000000

In particular notice:

#define MMU_FTR_RADIX			ASM_CONST(0x80000000)
                              mmu_features      = 0x0c000001

ie. MMU_FTR_RADIX is clear.

Do you see a different value for mmu_features?

cheers

  reply	other threads:[~2016-06-16 12:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-06  7:52 unrecoverable exception on G5 with CONFIG_PPC_EARLY_DEBUG enabled Denis Kirjanov
2016-06-06 12:27 ` Michael Ellerman
2016-06-16  8:12   ` Denis Kirjanov
2016-06-16 12:07     ` Michael Ellerman [this message]
2016-06-16 19:49       ` Denis Kirjanov
2016-06-16 22:33         ` Benjamin Herrenschmidt
2016-06-17  1:46           ` Michael Ellerman
2016-06-18 17:17             ` Aneesh Kumar K.V
2016-06-20  9:23               ` Michael Ellerman
2016-06-20 10:21                 ` Aneesh Kumar K.V
2016-06-21  0:59                   ` Michael Ellerman
2016-06-21  4:23                 ` Denis Kirjanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466078830.19127.0.camel@ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=kda@linux-powerpc.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).