From: Michael Ellerman <mpe@ellerman.id.au>
To: Joe Perches <joe@perches.com>,
Colin Ian King <colin.king@canonical.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Jiri Kosina <trivial@kernel.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: powerpc/fadump: trivial fix of spelling mistake, clean up message
Date: Mon, 27 Jun 2016 21:20:27 +1000 [thread overview]
Message-ID: <1467026427.29808.4.camel@ellerman.id.au> (raw)
In-Reply-To: <1467024695.1847.87.camel@perches.com>
On Mon, 2016-06-27 at 03:51 -0700, Joe Perches wrote:
> On Mon, 2016-06-27 at 11:38 +0100, Colin Ian King wrote:
> > On 26/06/16 05:19, Michael Ellerman wrote:
> > > On Fri, 2016-24-06 at 17:43:00 UTC, Colin King wrote:
> > > > trivial fix to spelling mistake "rgistration" and minor clean up
> > > > of the printk error message
> > > Can you also:
> > > - use pr_err()
> > > - unsplit the message, ie. keep the string all on one line.
> > I can unsplit the string, but checkpatch will complain about that, so
> > I'm not sure if that's preferred or not.
> >
> > WARNING: line over 80 characters
>
> If the statement is wrapped after the format,
> then checkpatch shouldn't complain.
>
> pr_err("Failed to invalidate firmware-assisted dump registration. Unexpected error (%d).\n",
> rc);
But that's not actually any more readable, so just ignore checkpatch in this
case IMHO. It's a guide, not the gospel.
cheers
next prev parent reply other threads:[~2016-06-27 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 17:43 [PATCH] powerpc/fadump: trivial fix of spelling mistake, clean up message Colin King
2016-06-26 4:19 ` Michael Ellerman
2016-06-27 10:38 ` Colin Ian King
2016-06-27 10:51 ` Joe Perches
2016-06-27 11:20 ` Michael Ellerman [this message]
2016-06-27 11:33 ` Joe Perches
2016-06-27 11:34 ` Colin Ian King
2016-06-28 3:50 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467026427.29808.4.camel@ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=colin.king@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).