From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rdRZJ1333zDqnV for ; Mon, 27 Jun 2016 21:30:31 +1000 (AEST) From: Benjamin Herrenschmidt To: linuxppc-dev@lists.ozlabs.org Subject: [PATCH 10/38] powerpc: Add comment explaining the purpose of setup_kdump_trampoline() Date: Mon, 27 Jun 2016 21:29:08 +1000 Message-Id: <1467026976-7974-11-git-send-email-benh@kernel.crashing.org> In-Reply-To: <1467026976-7974-1-git-send-email-benh@kernel.crashing.org> References: <1467026976-7974-1-git-send-email-benh@kernel.crashing.org> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Anything in early_setup() needs to be justified to be there, in this case, we need the trampolines before we can take exceptions and thus before we turn on the MMU. Also remove a pretty meaningless and misplaced debug message Signed-off-by: Benjamin Herrenschmidt --- arch/powerpc/kernel/setup_64.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/setup_64.c b/arch/powerpc/kernel/setup_64.c index e1b2e6f..a641753 100644 --- a/arch/powerpc/kernel/setup_64.c +++ b/arch/powerpc/kernel/setup_64.c @@ -276,10 +276,11 @@ void __init early_setup(unsigned long dt_ptr) /* Probe the machine type */ probe_machine(); + /* Setup the trampolines from the lowmem exception vectors + * to the kdump kernel when not using a relocatable kernel. + */ setup_kdump_trampoline(); - DBG("Found, Initializing memory management...\n"); - /* Initialize the hash table or TLB handling */ early_init_mmu(); -- 2.7.4