From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
To: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Cc: paulmck@linux.vnet.ibm.com, peterz@infradead.org,
mingo@redhat.com, mpe@ellerman.id.au, paulus@samba.org,
benh@kernel.crashing.org, Waiman.Long@hpe.com,
boqun.feng@gmail.com, will.deacon@arm.com, dave@stgolabs.net,
Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Subject: [PATCH 0/3] implement vcpu preempted check
Date: Mon, 27 Jun 2016 13:41:27 -0400 [thread overview]
Message-ID: <1467049290-32359-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> (raw)
This is to fix some bad issues on an over-committed guest.
test-caes:
perf record -a perf bench sched messaging -g 400 -p && perf report
18.09% sched-messaging [kernel.vmlinux] [k] osq_lock
12.28% sched-messaging [kernel.vmlinux] [k] rwsem_spin_on_owner
5.27% sched-messaging [kernel.vmlinux] [k] mutex_unlock
3.89% sched-messaging [kernel.vmlinux] [k] wait_consider_task
3.64% sched-messaging [kernel.vmlinux] [k] _raw_write_lock_irq
3.41% sched-messaging [kernel.vmlinux] [k] mutex_spin_on_owner.is
2.49% sched-messaging [kernel.vmlinux] [k] system_call
osq takes a long time with preemption disabled which is really bad.
This is because vCPU A hold the osq lock and yield out, vCPU B wait
per_cpu node->locked to be set. IOW, vCPU B wait vCPU A to run and
unlock the osq lock. Even there is need_resched(), it did not help on
such scenario.
we may also need fix other XXX_spin_on_owner later based on this patch set.
these spin_on_onwer variant cause rcu stall.
Pan Xinhui (3):
powerpc/spinlock: support vcpu preempted check
locking/osq: Drop the overload of osq_lock()
kernel/sched: introduce vcpu preempted check interface
arch/powerpc/include/asm/lppaca.h | 6 ++++++
arch/powerpc/include/asm/spinlock.h | 15 +++++++++++++++
include/linux/sched.h | 9 +++++++++
kernel/locking/osq_lock.c | 16 +++++++++++++++-
4 files changed, 45 insertions(+), 1 deletion(-)
--
2.4.11
next reply other threads:[~2016-06-27 13:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 17:41 Pan Xinhui [this message]
2016-06-27 17:41 ` [PATCH 1/3] kernel/sched: introduce vcpu preempted check interface Pan Xinhui
2016-06-27 14:00 ` Peter Zijlstra
2016-06-27 14:02 ` Peter Zijlstra
2016-06-28 3:14 ` xinhui
2016-06-28 7:00 ` Heiko Carstens
2016-06-28 9:47 ` xinhui
2016-06-27 14:05 ` Boqun Feng
2016-06-28 3:15 ` xinhui
2016-06-27 17:41 ` [PATCH 2/3] powerpc/spinlock: support vcpu preempted check Pan Xinhui
2016-06-27 14:17 ` Peter Zijlstra
2016-06-28 3:23 ` xinhui
2016-06-27 14:58 ` Boqun Feng
2016-06-28 3:39 ` xinhui
2016-06-28 5:03 ` Boqun Feng
2016-06-28 5:38 ` xinhui
2016-06-27 17:41 ` [PATCH 3/3] locking/osq: Drop the overload of osq_lock() Pan Xinhui
2016-06-27 14:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467049290-32359-1-git-send-email-xinhui.pan@linux.vnet.ibm.com \
--to=xinhui.pan@linux.vnet.ibm.com \
--cc=Waiman.Long@hpe.com \
--cc=benh@kernel.crashing.org \
--cc=boqun.feng@gmail.com \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=paulmck@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).