From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Binderman <linuxdev.baldrick@gmail.com>,
Michael Ellerman <mpe@ellerman.id.au>
Cc: paulus@samba.org, linuxppc-dev@lists.ozlabs.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dcb314@hotmail.com
Subject: Re: arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ?
Date: Tue, 28 Jun 2016 19:35:10 +1000 [thread overview]
Message-ID: <1467106510.20278.119.camel@kernel.crashing.org> (raw)
In-Reply-To: <CAMzoambZ9wu3orkFfYemTQiMpf+OWPdk8v6_SXsJapS74HE13A@mail.gmail.com>
On Tue, 2016-06-28 at 08:06 +0100, David Binderman wrote:
>
> I don't know the code, but given that insn is unsigned long and so
> can go
> past 32 bits, using a cast to unsigned int might throw away the
> possibly important
> upper bits.
our instructions are only ever 32-bits. That xmon code is ancient and
originated from 32-bits stuff. In fact some of Paulus earliest xmons
might even have run on platforms where int is 16 bits :-)
Cheers,
Ben.
prev parent reply other threads:[~2016-06-28 10:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 8:04 arch/powerpc/xmon/dis-asm.h: 2 * wrong specifiers ? David Binderman
2016-06-28 4:08 ` Michael Ellerman
2016-06-28 7:06 ` David Binderman
2016-06-28 7:17 ` Michael Ellerman
2016-06-28 7:30 ` Segher Boessenkool
2016-06-28 9:35 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467106510.20278.119.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=dcb314@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxdev.baldrick@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).