linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
To: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	virtualization@lists.linux-foundation.org,
	linux-s390@vger.kernel.org
Cc: peterz@infradead.org, mingo@redhat.com, mpe@ellerman.id.au,
	paulus@samba.org, benh@kernel.crashing.org,
	paulmck@linux.vnet.ibm.com, waiman.long@hpe.com,
	will.deacon@arm.com, boqun.feng@gmail.com, dave@stgolabs.net,
	schwidefsky@de.ibm.com,
	Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
Subject: [PATCH v2 0/4] implement vcpu preempted check
Date: Tue, 28 Jun 2016 10:43:07 -0400	[thread overview]
Message-ID: <1467124991-13164-1-git-send-email-xinhui.pan@linux.vnet.ibm.com> (raw)

change fomr v1:
	a simplier definition of default vcpu_is_preempted
	skip mahcine type check on ppc, and add config. remove dedicated macro.
	add one patch to drop overload of rwsem_spin_on_owner and mutex_spin_on_owner. 
	add more comments
	thanks boqun and Peter's suggestion.

This patch set aims to fix lock holder preemption issues.

test-case:
perf record -a perf bench sched messaging -g 400 -p && perf report

18.09%  sched-messaging  [kernel.vmlinux]  [k] osq_lock
12.28%  sched-messaging  [kernel.vmlinux]  [k] rwsem_spin_on_owner
 5.27%  sched-messaging  [kernel.vmlinux]  [k] mutex_unlock
 3.89%  sched-messaging  [kernel.vmlinux]  [k] wait_consider_task
 3.64%  sched-messaging  [kernel.vmlinux]  [k] _raw_write_lock_irq
 3.41%  sched-messaging  [kernel.vmlinux]  [k] mutex_spin_on_owner.is
 2.49%  sched-messaging  [kernel.vmlinux]  [k] system_call

We introduce interface bool vcpu_is_preempted(int cpu) and use it in some spin
loops of osq_lock, rwsem_spin_on_owner and mutex_spin_on_owner.
These spin_on_onwer variant also cause rcu stall before we apply this patch set

Pan Xinhui (4):
  kernel/sched: introduce vcpu preempted check interface
  powerpc/spinlock: support vcpu preempted check
  locking/osq: Drop the overload of osq_lock()
  kernel/locking: Drop the overload of {mutex,rwsem}_spin_on_owner

 arch/powerpc/include/asm/spinlock.h | 18 ++++++++++++++++++
 include/linux/sched.h               | 12 ++++++++++++
 kernel/locking/mutex.c              | 15 +++++++++++++--
 kernel/locking/osq_lock.c           | 10 +++++++++-
 kernel/locking/rwsem-xadd.c         | 16 +++++++++++++---
 5 files changed, 65 insertions(+), 6 deletions(-)

-- 
2.4.11

             reply	other threads:[~2016-06-28 10:44 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-28 14:43 Pan Xinhui [this message]
2016-06-28 14:43 ` [PATCH v2 1/4] kernel/sched: introduce vcpu preempted check interface Pan Xinhui
2016-06-28 14:43 ` [PATCH v2 2/4] powerpc/spinlock: support vcpu preempted check Pan Xinhui
2016-07-05  9:57   ` Wanpeng Li
2016-07-06  4:58     ` xinhui
2016-07-06  6:46       ` Wanpeng Li
2016-07-06  7:58         ` Peter Zijlstra
2016-07-06  8:32           ` Wanpeng Li
2016-07-06 10:18             ` xinhui
2016-07-06 10:54   ` Balbir Singh
2016-07-15 15:35     ` Pan Xinhui
2016-06-28 14:43 ` [PATCH v2 3/4] locking/osq: Drop the overload of osq_lock() Pan Xinhui
2016-06-28 14:43 ` [PATCH v2 4/4] kernel/locking: Drop the overload of {mutex, rwsem}_spin_on_owner Pan Xinhui
2016-07-06  6:52 ` [PATCH v2 0/4] implement vcpu preempted check Peter Zijlstra
2016-07-06  7:47   ` Juergen Gross
2016-07-06  8:19     ` Peter Zijlstra
2016-07-06  8:38       ` Juergen Gross
2016-07-06 12:44       ` Paolo Bonzini
2016-07-06 16:56       ` Christian Borntraeger
2016-07-06 10:05   ` xinhui
2016-07-06 10:44   ` Paolo Bonzini
2016-07-06 11:59     ` Peter Zijlstra
2016-07-06 12:08     ` Wanpeng Li
2016-07-06 12:28       ` Paolo Bonzini
2016-07-06 13:03         ` Wanpeng Li
2016-07-07  8:48         ` Wanpeng Li
2016-07-07  9:42           ` Peter Zijlstra
2016-07-07 10:12             ` Wanpeng Li
2016-07-07 10:27               ` Wanpeng Li
2016-07-07 11:15                 ` Peter Zijlstra
2016-07-07 11:08               ` Peter Zijlstra
2016-07-07 11:09             ` Peter Zijlstra
2016-07-07 11:21             ` Peter Zijlstra
2016-07-11 15:10   ` Waiman Long
2016-07-12  4:16     ` Juergen Gross
2016-07-12 18:16       ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1467124991-13164-1-git-send-email-xinhui.pan@linux.vnet.ibm.com \
    --to=xinhui.pan@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=boqun.feng@gmail.com \
    --cc=dave@stgolabs.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=waiman.long@hpe.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).