From: Ian Munsie <imunsie@au1.ibm.com>
To: "andrew.donnellan" <andrew.donnellan@au1.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>, mikey <mikey@neuling.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Frederic Barrat <frederic.barrat@fr.ibm.com>,
Huy Nguyen <huyn@mellanox.com>
Subject: Re: [PATCH] cxl: Fix NULL pointer dereference on kernel contexts with no AFU interrupts
Date: Thu, 30 Jun 2016 16:24:31 +1000 [thread overview]
Message-ID: <1467267733-sup-444@x230.ozlabs.ibm.com> (raw)
In-Reply-To: <e17203b8-0662-e110-f6f6-ab41617db45a@au1.ibm.com>
Excerpts from andrew.donnellan's message of 2016-06-30 15:15:02 +1000:
> On 30/06/16 15:00, Michael Ellerman wrote:
> > On Thu, 2016-06-30 at 08:28 +1000, Andrew Donnellan wrote:
> >> On 30/06/16 04:55, Ian Munsie wrote:
> >>>
> >>> From: Ian Munsie <imunsie@au1.ibm.com>
> >>>
> >>> If a kernel context is initialised and does not have any AFU interrupts
> >>> allocated it will cause a NULL pointer dereference when the context is
> >>> detached since the irq_names list will not have been initialised.
> >>>
> >>> Move the initialisation of the irq_names list into the cxl_context_init
> >>> routine so that it will be valid for the entire lifetime of the context
> >>> and will not cause a NULL pointer dereference.
> >>>
> >>> Signed-off-by: Ian Munsie <imunsie@au1.ibm.com>
> >
> >> As it's nice having your machine not crash on every shutdown...
> >
> > Fixes: ????
>
> Ian can correct me if I'm wrong, but I suspect this doesn't affect
> cxlflash (the only current user of the cxl kernel API) - this issue was
> hit while working on CAPI support for mlx5.
Correct - no current user hits this bug, but the upcoming mlx5 support
does because of the way it uses interrupts.
-Ian
next prev parent reply other threads:[~2016-06-30 6:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 18:55 [PATCH] cxl: Fix NULL pointer dereference on kernel contexts with no AFU interrupts Ian Munsie
2016-06-29 22:28 ` Andrew Donnellan
2016-06-30 5:00 ` Michael Ellerman
2016-06-30 5:15 ` Andrew Donnellan
2016-06-30 6:24 ` Ian Munsie [this message]
2016-07-11 10:19 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467267733-sup-444@x230.ozlabs.ibm.com \
--to=imunsie@au1.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=frederic.barrat@fr.ibm.com \
--cc=huyn@mellanox.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).