From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Russell Currey <ruscur@russell.cc>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/pci: Fix build with PCI_IOV=y and EEH=n
Date: Tue, 05 Jul 2016 15:16:41 +1000 [thread overview]
Message-ID: <1467695801.13965.34.camel@au1.ibm.com> (raw)
In-Reply-To: <1467693015.23386.1.camel@russell.cc>
On Tue, 2016-07-05 at 14:30 +1000, Russell Currey wrote:
> On Tue, 2016-07-05 at 14:13 +1000, Michael Ellerman wrote:
> > Despite attempting to fix this in commit fb36e9073693
> ("powerpc/pci: Fix
> > SRIOV not building without EEH enabled"), the build is still broken
> when
> > PCI_IOV=y and EEH=n (eg. g5_defconfig with PCI_IOV=y):
> >
> > arch/powerpc/kernel/pci_dn.c: In function ‘remove_dev_pci_data’:
> > arch/powerpc/kernel/pci_dn.c:230:18: error: unused variable
> ‘edev’
> >
> > Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> > ---
>
> Mistakes were made.
The fix [PATCH 40/41] powerpc/pci: Fix build of Book3E/64 without EEH
in my series should subsume this... provided I didnt screw up that is
:-)
Cheers,
Ben.
prev parent reply other threads:[~2016-07-05 5:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 4:13 [PATCH] powerpc/pci: Fix build with PCI_IOV=y and EEH=n Michael Ellerman
2016-07-05 4:30 ` Russell Currey
2016-07-05 5:16 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1467695801.13965.34.camel@au1.ibm.com \
--to=benh@au1.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=ruscur@russell.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).