* [PATCH] powerpc/configs: Enable VMX crypto
@ 2016-07-11 23:25 Anton Blanchard
2016-07-11 23:33 ` Stephen Rothwell
0 siblings, 1 reply; 6+ messages in thread
From: Anton Blanchard @ 2016-07-11 23:25 UTC (permalink / raw)
To: benh, paulus, mpe; +Cc: linuxppc-dev
From: Anton Blanchard <anton@samba.org>
We see big improvements with the VMX crypto functions (often 10x or more),
so enable it as a module.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
arch/powerpc/configs/powernv_defconfig | 2 ++
arch/powerpc/configs/pseries_defconfig | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig
index dce352e..3f6226b 100644
--- a/arch/powerpc/configs/powernv_defconfig
+++ b/arch/powerpc/configs/powernv_defconfig
@@ -310,6 +310,8 @@ CONFIG_CRYPTO_TEA=m
CONFIG_CRYPTO_TWOFISH=m
CONFIG_CRYPTO_LZO=m
CONFIG_CRYPTO_DEV_NX=y
+CONFIG_CRYPTO_DEV_VMX=y
+CONFIG_CRYPTO_DEV_VMX_ENCRYPT=m
CONFIG_VIRTUALIZATION=y
CONFIG_KVM_BOOK3S_64=m
CONFIG_KVM_BOOK3S_64_HV=m
diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
index 99dec9d..1d7eea2 100644
--- a/arch/powerpc/configs/pseries_defconfig
+++ b/arch/powerpc/configs/pseries_defconfig
@@ -313,6 +313,8 @@ CONFIG_CRYPTO_LZO=m
# CONFIG_CRYPTO_ANSI_CPRNG is not set
CONFIG_CRYPTO_DEV_NX=y
CONFIG_CRYPTO_DEV_NX_ENCRYPT=m
+CONFIG_CRYPTO_DEV_VMX=y
+CONFIG_CRYPTO_DEV_VMX_ENCRYPT=m
CONFIG_VIRTUALIZATION=y
CONFIG_KVM_BOOK3S_64=m
CONFIG_KVM_BOOK3S_64_HV=m
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/configs: Enable VMX crypto
2016-07-11 23:25 [PATCH] powerpc/configs: Enable VMX crypto Anton Blanchard
@ 2016-07-11 23:33 ` Stephen Rothwell
2016-07-11 23:41 ` Anton Blanchard
0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2016-07-11 23:33 UTC (permalink / raw)
To: Anton Blanchard; +Cc: benh, paulus, mpe, linuxppc-dev
Hi Anton,
On Tue, 12 Jul 2016 09:25:21 +1000 Anton Blanchard <anton@ozlabs.org> wrote:
>
> From: Anton Blanchard <anton@samba.org>
>
> We see big improvements with the VMX crypto functions (often 10x or more),
> so enable it as a module.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> ---
> arch/powerpc/configs/powernv_defconfig | 2 ++
> arch/powerpc/configs/pseries_defconfig | 2 ++
> 2 files changed, 4 insertions(+)
Not in ppc64_defconfig?
--
Cheers,
Stephen Rothwell
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/configs: Enable VMX crypto
2016-07-11 23:33 ` Stephen Rothwell
@ 2016-07-11 23:41 ` Anton Blanchard
2016-07-12 4:17 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Anton Blanchard @ 2016-07-11 23:41 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: benh, paulus, mpe, linuxppc-dev
Hi Steven,
> Not in ppc64_defconfig?
Good point. The recent addition of powernv_defconfig made me forget
about ppc64_defconfig. We could do with some rationalisation here.
pseries isn't really pseries, perhaps we should call it ibm_defconfig,
or maybe server_deconfig. ppc64_defconfig continues to be the lower end
defconfig.
Anton
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/configs: Enable VMX crypto
2016-07-11 23:41 ` Anton Blanchard
@ 2016-07-12 4:17 ` Michael Ellerman
0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2016-07-12 4:17 UTC (permalink / raw)
To: Anton Blanchard, Stephen Rothwell; +Cc: benh, paulus, linuxppc-dev
Anton Blanchard <anton@samba.org> writes:
> Hi Steven,
>
>> Not in ppc64_defconfig?
>
> Good point. The recent addition of powernv_defconfig made me forget
> about ppc64_defconfig. We could do with some rationalisation here.
Understatement of the century.
> pseries isn't really pseries, perhaps we should call it ibm_defconfig,
> or maybe server_deconfig.
pseries should be just pseries, and nothing else.
> ppc64_defconfig continues to be the lower end defconfig.
ppc64_defconfig *should* be the primary config. And similarly ppc64le
when building little endian.
The reason being that 'make defconfig' will give you one of those
depending on uname (when building native).
I think the only thing disqualifying it from that role at the moment is
that it builds 4K pages.
But I think we should just change that. We can add ppc64_4K_defconfig
for anyone who wants it (G5 users mainly I would guess).
We'd also need to make sure ppc64/ppc64le have all the modern options
enabled.
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] powerpc/configs: Enable VMX crypto
@ 2016-07-11 23:43 Anton Blanchard
2016-07-14 10:13 ` Michael Ellerman
0 siblings, 1 reply; 6+ messages in thread
From: Anton Blanchard @ 2016-07-11 23:43 UTC (permalink / raw)
To: benh, paulus, mpe; +Cc: linuxppc-dev
From: Anton Blanchard <anton@samba.org>
We see big improvements with the VMX crypto functions (often 10x or more),
so enable it as a module.
Signed-off-by: Anton Blanchard <anton@samba.org>
---
arch/powerpc/configs/powernv_defconfig | 2 ++
arch/powerpc/configs/ppc64_defconfig | 2 ++
arch/powerpc/configs/pseries_defconfig | 2 ++
3 files changed, 6 insertions(+)
diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs/powernv_defconfig
index dce352e..3f6226b 100644
--- a/arch/powerpc/configs/powernv_defconfig
+++ b/arch/powerpc/configs/powernv_defconfig
@@ -310,6 +310,8 @@ CONFIG_CRYPTO_TEA=m
CONFIG_CRYPTO_TWOFISH=m
CONFIG_CRYPTO_LZO=m
CONFIG_CRYPTO_DEV_NX=y
+CONFIG_CRYPTO_DEV_VMX=y
+CONFIG_CRYPTO_DEV_VMX_ENCRYPT=m
CONFIG_VIRTUALIZATION=y
CONFIG_KVM_BOOK3S_64=m
CONFIG_KVM_BOOK3S_64_HV=m
diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig
index 0a8d250..861471d 100644
--- a/arch/powerpc/configs/ppc64_defconfig
+++ b/arch/powerpc/configs/ppc64_defconfig
@@ -347,6 +347,8 @@ CONFIG_CRYPTO_LZO=m
# CONFIG_CRYPTO_ANSI_CPRNG is not set
CONFIG_CRYPTO_DEV_NX=y
CONFIG_CRYPTO_DEV_NX_ENCRYPT=m
+CONFIG_CRYPTO_DEV_VMX=y
+CONFIG_CRYPTO_DEV_VMX_ENCRYPT=m
CONFIG_VIRTUALIZATION=y
CONFIG_KVM_BOOK3S_64=m
CONFIG_KVM_BOOK3S_64_HV=m
diff --git a/arch/powerpc/configs/pseries_defconfig b/arch/powerpc/configs/pseries_defconfig
index 99dec9d..1d7eea2 100644
--- a/arch/powerpc/configs/pseries_defconfig
+++ b/arch/powerpc/configs/pseries_defconfig
@@ -313,6 +313,8 @@ CONFIG_CRYPTO_LZO=m
# CONFIG_CRYPTO_ANSI_CPRNG is not set
CONFIG_CRYPTO_DEV_NX=y
CONFIG_CRYPTO_DEV_NX_ENCRYPT=m
+CONFIG_CRYPTO_DEV_VMX=y
+CONFIG_CRYPTO_DEV_VMX_ENCRYPT=m
CONFIG_VIRTUALIZATION=y
CONFIG_KVM_BOOK3S_64=m
CONFIG_KVM_BOOK3S_64_HV=m
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] powerpc/configs: Enable VMX crypto
2016-07-11 23:43 Anton Blanchard
@ 2016-07-14 10:13 ` Michael Ellerman
0 siblings, 0 replies; 6+ messages in thread
From: Michael Ellerman @ 2016-07-14 10:13 UTC (permalink / raw)
To: Anton Blanchard, benh, paulus; +Cc: linuxppc-dev
Anton Blanchard <anton@ozlabs.org> writes:
> From: Anton Blanchard <anton@samba.org>
>
> We see big improvements with the VMX crypto functions (often 10x or more),
> so enable it as a module.
I can't build pseries_defconfig with this applied:
/tmp/ccsjEdNB.s: Assembler messages:
/tmp/ccsjEdNB.s: Error: .size expression for aes_p8_set_encrypt_key does not evaluate to a constant
/tmp/ccsjEdNB.s: Error: .size expression for aes_p8_set_decrypt_key does not evaluate to a constant
/tmp/ccsjEdNB.s: Error: .size expression for aes_p8_encrypt does not evaluate to a constant
/tmp/ccsjEdNB.s: Error: .size expression for aes_p8_decrypt does not evaluate to a constant
/tmp/ccsjEdNB.s: Error: .size expression for aes_p8_cbc_encrypt does not evaluate to a constant
/tmp/ccsjEdNB.s: Error: .size expression for aes_p8_ctr32_encrypt_blocks does not evaluate to a constant
That's with GCC 6.1.0 / binutils 2.26.
Haven't debugged it any further.
cheers
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-14 10:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-11 23:25 [PATCH] powerpc/configs: Enable VMX crypto Anton Blanchard
2016-07-11 23:33 ` Stephen Rothwell
2016-07-11 23:41 ` Anton Blanchard
2016-07-12 4:17 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2016-07-11 23:43 Anton Blanchard
2016-07-14 10:13 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).