From: Ian Munsie <imunsie@au1.ibm.com>
To: "andrew.donnellan" <andrew.donnellan@au1.ibm.com>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Michael Neuling <mikey@neuling.org>,
Frederic Barrat <fbarrat@linux.vnet.ibm.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Huy Nguyen <huyn@mellanox.com>
Subject: Re: [PATCH 05/15] cxl: Allow a default context to be associated with an external pci_dev
Date: Thu, 14 Jul 2016 07:05:14 +1000 [thread overview]
Message-ID: <1468442596-sup-1930@x230.ozlabs.ibm.com> (raw)
In-Reply-To: <0a7c4db6-7f48-be69-81e0-ca1ede3f6cea@au1.ibm.com>
Excerpts from andrew.donnellan's message of 2016-07-13 15:52:45 +1000:
> > +bool _cxl_pci_associate_default_context(struct pci_dev *dev, struct cxl_afu *afu)
>
> If we're sharing these functions between the vPHB and peer models, do we
> have a better place than vphb.c for them?
Sure, I might split them out into a new phb.c for V3. It just seemed a
little pointless to create a new file for two functions at the time, but
you are right that they don't really belong in vphb.c. I guess an
alternative would be to rename vphb.c to phb.c, but 90% of that file is
vphb specific... I'll split these out.
> > +{
> > + struct cxl_context *ctx;
> > +
> > + /*
> > + * Allocate a context to do cxl things too. This is used for interrupts
>
> s/too/to/?
Heh, the one part of the comment that I didn't change from Mikey's code ;-P
Will fix.
Cheers,
-Ian
next prev parent reply other threads:[~2016-07-13 21:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 11:50 [PATCH v2] powerpc / cxl: Add support for the Mellanox CX4 in cxl mode Ian Munsie
2016-07-11 11:50 ` [PATCH 01/15] powerpc/powernv: Split cxl code out into a separate file Ian Munsie
2016-07-11 11:50 ` [PATCH 02/15] cxl: Add cxl_slot_is_supported API Ian Munsie
2016-07-11 11:50 ` [PATCH 03/15] cxl: Enable bus mastering for devices using CAPP DMA mode Ian Munsie
2016-07-11 11:50 ` [PATCH 04/15] cxl: Move cxl_afu_get / cxl_afu_put to base Ian Munsie
2016-07-11 11:50 ` [PATCH 05/15] cxl: Allow a default context to be associated with an external pci_dev Ian Munsie
2016-07-13 5:52 ` Andrew Donnellan
2016-07-13 21:05 ` Ian Munsie [this message]
2016-07-11 11:50 ` [PATCH 06/15] cxl: Do not create vPHB if there are no AFU configuration records Ian Munsie
2016-07-12 9:05 ` Andrew Donnellan
2016-07-11 11:50 ` [PATCH 07/15] powerpc/powernv: Add support for the cxl kernel api on the real phb Ian Munsie
2016-07-12 10:39 ` Andrew Donnellan
2016-07-13 20:39 ` Ian Munsie
2016-07-11 11:50 ` [PATCH 08/15] cxl: Add support for using the kernel API with a real PHB Ian Munsie
2016-07-12 10:48 ` Andrew Donnellan
2016-07-11 11:50 ` [PATCH 09/15] cxl: Add kernel APIs to get & set the max irqs per context Ian Munsie
2016-07-12 5:48 ` Andrew Donnellan
2016-07-11 11:50 ` [PATCH 10/15] cxl: Add preliminary workaround for CX4 interrupt limitation Ian Munsie
2016-07-13 4:40 ` Andrew Donnellan
2016-07-11 11:50 ` [PATCH 11/15] cxl: Add support for interrupts on the Mellanox CX4 Ian Munsie
2016-07-11 11:50 ` [PATCH 12/15] cxl: Workaround PE=0 hardware limitation in " Ian Munsie
2016-07-11 11:50 ` [PATCH 13/15] PCI/hotplug: pnv_php: export symbols and move struct types needed by cxl Ian Munsie
2016-07-11 11:50 ` [PATCH 14/15] PCI/hotplug: pnv_php: handle OPAL_PCI_SLOT_OFFLINE power state Ian Munsie
2016-07-11 11:50 ` [PATCH 15/15] cxl: Add cxl_check_and_switch_mode() API to switch bi-modal cards Ian Munsie
-- strict thread matches above, loose matches on Subject: below --
2016-07-13 21:16 [PATCH v3] powerpc / cxl: Add support for the Mellanox CX4 in cxl mode Ian Munsie
2016-07-13 21:17 ` [PATCH 05/15] cxl: Allow a default context to be associated with an external pci_dev Ian Munsie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468442596-sup-1930@x230.ozlabs.ibm.com \
--to=imunsie@au1.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=huyn@mellanox.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).