From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ozlabs.org (ozlabs.org [103.22.144.67]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ryTCK1PVWzDqTm for ; Mon, 25 Jul 2016 14:43:09 +1000 (AEST) Message-ID: <1469421764.5978.4.camel@kernel.crashing.org> Subject: Re: [PATCH 2/3] powerpc/mm: Rename hpte_init_lpar() & put fallback in a header From: Benjamin Herrenschmidt To: Stephen Rothwell , Michael Ellerman Cc: linuxppc-dev@ozlabs.org Date: Mon, 25 Jul 2016 14:42:44 +1000 In-Reply-To: <20160725141326.6a155483@canb.auug.org.au> References: <1469415471-2476-1-git-send-email-mpe@ellerman.id.au> <1469415471-2476-2-git-send-email-mpe@ellerman.id.au> <20160725141326.6a155483@canb.auug.org.au> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, 2016-07-25 at 14:13 +1000, Stephen Rothwell wrote: > Hi Michael, > > On Mon, 25 Jul 2016 12:57:50 +1000 Michael Ellerman wrote: > > > > hpte_init_lpar() is part of the pseries platform, so name it as such. > > Provide the fallback implementation in a header, rather than using a > > weak function. > > firmware_has_feature(FW_FEATURE_LPAR) can also be true for > CONFIG_PPC_PS3.  Is this a problem? Shouldn't be with my latest series Cheers, Ben.