From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
mpe@ellerman.id.au, anton@samba.org, paulus@samba.org
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 0/9]powerpc: "paca->soft_enabled" based local atomic operation implementation
Date: Tue, 26 Jul 2016 22:21:14 +1000 [thread overview]
Message-ID: <1469535674.5978.73.camel@kernel.crashing.org> (raw)
In-Reply-To: <1469458342-26233-1-git-send-email-maddy@linux.vnet.ibm.com>
On Mon, 2016-07-25 at 20:22 +0530, Madhavan Srinivasan wrote:
> But this patchset uses Benjamin Herrenschmidt suggestion of using
> arch_local_irq_disable_var() to soft_disable interrupts (including PMIs).
> After finishing the "op", arch_local_irq_restore() called and correspondingly
> interrupts are replayed if any occured.
I am not fan of "var", we probably want "level".
Also be careful, you might be already soft-disabled at level 1, you
must restore to level 1, not level 0 in that case. Might want to
actually return the level in "flags" and restore that.
Cheers,
Ben.
next prev parent reply other threads:[~2016-07-26 12:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 14:52 [RFC PATCH 0/9]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2016-07-25 14:52 ` [RFC PATCH 1/9] Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2016-07-26 5:27 ` Nicholas Piggin
2016-07-26 6:05 ` Madhavan Srinivasan
2016-07-26 6:13 ` Nicholas Piggin
2016-07-28 13:54 ` Nicholas Piggin
2016-07-25 14:52 ` [RFC PATCH 2/9] Cleanup to use LAZY_INTERRUPT_* macros for paca->soft_enabled update Madhavan Srinivasan
2016-07-25 14:52 ` [RFC PATCH 3/9] powerpc: move set_soft_enabled() Madhavan Srinivasan
2016-07-25 14:52 ` [RFC PATCH 4/9] powerpc: Use set_soft_enabled api to update paca->soft_enabled Madhavan Srinivasan
2016-07-25 14:52 ` [RFC PATCH 5/9] powerpc: reverse the soft_enable logic Madhavan Srinivasan
2016-07-26 5:31 ` Nicholas Piggin
2016-07-26 6:07 ` Madhavan Srinivasan
2016-07-25 14:52 ` [RFC PATCH 6/9] powerpc: modify __SOFTEN_TEST to support tri-state soft_enabled flag Madhavan Srinivasan
2016-07-26 5:41 ` Nicholas Piggin
2016-07-26 6:12 ` Madhavan Srinivasan
2016-07-25 14:52 ` [RFC PATCH 7/9] powerpc: Add support to mask perf interrupts Madhavan Srinivasan
2016-07-26 5:46 ` Nicholas Piggin
2016-07-26 6:25 ` Madhavan Srinivasan
2016-07-26 6:30 ` Nicholas Piggin
2016-07-26 6:46 ` Madhavan Srinivasan
2016-07-26 7:10 ` Nicholas Piggin
2016-07-26 7:22 ` Madhavan Srinivasan
2016-07-26 7:34 ` Nicholas Piggin
2016-07-25 14:52 ` [RFC PATCH 8/9] powerpc: Support to replay PMIs Madhavan Srinivasan
2016-07-26 5:50 ` Nicholas Piggin
2016-07-26 6:40 ` Madhavan Srinivasan
2016-07-25 14:52 ` [RFC PATCH 9/9] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan
2016-07-26 5:53 ` Nicholas Piggin
2016-07-26 6:41 ` Madhavan Srinivasan
2016-07-26 12:21 ` Benjamin Herrenschmidt [this message]
2016-07-26 13:42 ` [RFC PATCH 0/9]powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469535674.5978.73.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).