From: Scott Wood <oss@buserror.net>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: linuxppc-dev@lists.ozlabs.org,
Kumar Gala <galak@kernel.crashing.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Alessio Igor Bogani <alessio.bogani@elettra.eu>,
Daniel Axtens <dja@axtens.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] powerpc: Convert fsl_rstcr_restart to a reset handler
Date: Tue, 26 Jul 2016 16:26:18 -0500 [thread overview]
Message-ID: <1469568378.25630.119.camel@buserror.net> (raw)
In-Reply-To: <CAHQ1cqE+-p00PwYCTA8SkAuqmQ+pkuzDfKJir7s+XR3GBzFZ2Q@mail.gmail.com>
On Tue, 2016-07-26 at 14:22 -0700, Andrey Smirnov wrote:
> On Tue, Jul 26, 2016 at 12:59 AM, Scott Wood <oss@buserror.net> wrote:
> >
> > On Mon, 2016-07-25 at 21:25 -0700, Andrey Smirnov wrote:
> > >
> > > Convert fsl_rstcr_restart into a function to be registered with
> > > register_reset_handler() API and introduce fls_rstcr_restart_register()
> > > function that can be added as an initcall that would do aforementioned
> > > registration.
> > >
> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > Is there a particular motivation for this (e.g. new handlers you plan to
> > register elsewhere)?
> I have a MPC8548 based board that which uses, at least for time being,
> SBC8548's init code(by claiming compatibility in DT) which has an
> external watchdog that implements reset functionality. The driver for
> watchdog is just a generic watchdog driver and having an ability to
> register custom reset handlers is very handy.
>
> I don't really have any motivation for fixing boards other than
> SBC8548 and even that I can avoid doing by making a new custom board
> file in my tree that would not populate .reset field. I can drop this
> patch from the series if the code of those boards is in "don't touch
> it unless absolutely have to" state.
I'm not saying not to touch it -- I just wanted to understand the context.
-Scott
prev parent reply other threads:[~2016-07-26 21:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-26 4:25 [PATCH 1/3] powerpc: Factor out common code in setup-common.c Andrey Smirnov
2016-07-26 4:25 ` [PATCH 2/3] powerpc: Call chained reset handlers during reset Andrey Smirnov
2016-07-26 4:25 ` [PATCH 3/3] powerpc: Convert fsl_rstcr_restart to a reset handler Andrey Smirnov
2016-07-26 7:59 ` Scott Wood
2016-07-26 21:22 ` Andrey Smirnov
2016-07-26 21:26 ` Scott Wood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469568378.25630.119.camel@buserror.net \
--to=oss@buserror.net \
--cc=alessio.bogani@elettra.eu \
--cc=andrew.smirnov@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=dja@axtens.net \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).