linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
To: benh@kernel.crashing.org, mpe@ellerman.id.au
Cc: anton@samba.org, paulus@samba.org, npiggin@gmail.com,
	linuxppc-dev@lists.ozlabs.org,
	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: [RFC PATCH v2 10/11] powerpc: Support to replay PMIs
Date: Mon,  1 Aug 2016 00:36:28 +0530	[thread overview]
Message-ID: <1469991989-28409-11-git-send-email-maddy@linux.vnet.ibm.com> (raw)
In-Reply-To: <1469991989-28409-1-git-send-email-maddy@linux.vnet.ibm.com>

Code to replay the Performance Monitoring Interrupts(PMI).
In the masked_interrupt handler, for PMIs we reset the MSR[EE]
and return. This is due the fact that PMIs are level triggered.
In the __check_irq_replay(), we enabled the MSR[EE] which will
fire the interrupt for us.

Patch also adds a new arch_local_irq_disable_var() variant. New
variant takes an input value to write to the paca->soft_enabled.
This will be used in following patch to implement the tri-state
value for soft-enabled.

Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
---
 arch/powerpc/include/asm/hw_irq.h | 14 ++++++++++++++
 arch/powerpc/kernel/irq.c         |  9 ++++++++-
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/arch/powerpc/include/asm/hw_irq.h b/arch/powerpc/include/asm/hw_irq.h
index a7b86edc94bf..9f235d25b9f8 100644
--- a/arch/powerpc/include/asm/hw_irq.h
+++ b/arch/powerpc/include/asm/hw_irq.h
@@ -84,6 +84,20 @@ static inline unsigned long arch_local_irq_disable(void)
 	return flags;
 }
 
+static inline unsigned long soft_irq_set_level(int value)
+{
+	unsigned long flags, zero;
+
+	asm volatile(
+		"li %1,%3; lbz %0,%2(13); stb %1,%2(13)"
+		: "=r" (flags), "=&r" (zero)
+		: "i" (offsetof(struct paca_struct, soft_enabled)),\
+		  "i" (value)
+		: "memory");
+
+	return flags;
+}
+
 extern void arch_local_irq_restore(unsigned long);
 
 static inline void arch_local_irq_enable(void)
diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
index 857e1e8188e5..9d70e51db8bc 100644
--- a/arch/powerpc/kernel/irq.c
+++ b/arch/powerpc/kernel/irq.c
@@ -158,9 +158,16 @@ notrace unsigned int __check_irq_replay(void)
 	if ((happened & PACA_IRQ_DEC) || decrementer_check_overflow())
 		return 0x900;
 
+	/*
+	 * In masked_handler() for PMI, we disable MSR[EE] and return.
+	 * When replaying it, just enabling the MSR[EE] will do
+	 * trick, since the PMI are "level" triggered.
+	 */
+	local_paca->irq_happened &= ~PACA_IRQ_PMI;
+
 	/* Finally check if an external interrupt happened */
 	local_paca->irq_happened &= ~PACA_IRQ_EE;
-	if (happened & PACA_IRQ_EE)
+	if ((happened & PACA_IRQ_EE) || (happened & PACA_IRQ_PMI))
 		return 0x500;
 
 #ifdef CONFIG_PPC_BOOK3E
-- 
2.7.4

  parent reply	other threads:[~2016-07-31 19:07 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-31 19:06 [RFC PATCH v2 00/11] powerpc: "paca->soft_enabled" based local atomic operation implementation Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 01/11] Add #defs for paca->soft_enabled flags Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 02/11] Cleanup to use IRQ_DISABLE_LEVEL_* macros for paca->soft_enabled update Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 03/11] powerpc: move set_soft_enabled() Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 04/11] powerpc: Use set_soft_enabled api to update paca->soft_enabled Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 05/11] powerpc: reverse the soft_enable logic Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 06/11] powerpc: Avoid using EXCEPTION_PROLOG_1 macro in MASKABLE_* Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 07/11] powerpc: Add new _EXCEPTION_PROLOG_1 macro Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 08/11] powerpc: Add "mask_lvl" paramater to MASKABLE_* macros Madhavan Srinivasan
2016-08-01  5:21   ` Nicholas Piggin
2016-08-01  5:49     ` Madhavan Srinivasan
2016-07-31 19:06 ` [RFC PATCH v2 09/11] powerpc: Add support to mask perf interrupts Madhavan Srinivasan
2016-08-01  5:29   ` Nicholas Piggin
2016-08-01  6:09     ` Madhavan Srinivasan
2016-08-01  6:48       ` Nicholas Piggin
2016-07-31 19:06 ` Madhavan Srinivasan [this message]
2016-08-01  8:07   ` [RFC PATCH v2 10/11] powerpc: Support to replay PMIs Nicholas Piggin
2016-08-01  8:51     ` Benjamin Herrenschmidt
2016-08-01 10:22       ` Madhavan Srinivasan
2016-08-01 10:43         ` Nicholas Piggin
2016-08-01  8:52     ` Benjamin Herrenschmidt
2016-07-31 19:06 ` [RFC PATCH v2 11/11] powerpc: rewrite local_t using soft_irq Madhavan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1469991989-28409-11-git-send-email-maddy@linux.vnet.ibm.com \
    --to=maddy@linux.vnet.ibm.com \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).