* [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC
@ 2016-08-01 10:54 Michael Ellerman
2016-08-04 5:00 ` Anton Blanchard
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2016-08-01 10:54 UTC (permalink / raw)
To: herbert; +Cc: linuxppc-dev, Anton Blanchard
The optimised crc32c implementation depends on VMX (aka. Altivec)
instructions, so the kernel must be built with Altivec support in order
for the crc32c code to build.
Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/crypto/Kconfig b/crypto/Kconfig
index a9377bef25e3..84d71482bf08 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -439,7 +439,7 @@ config CRYPTO_CRC32C_INTEL
config CRYPT_CRC32C_VPMSUM
tristate "CRC32c CRC algorithm (powerpc64)"
- depends on PPC64
+ depends on PPC64 && ALTIVEC
select CRYPTO_HASH
select CRC32
help
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC
2016-08-01 10:54 [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC Michael Ellerman
@ 2016-08-04 5:00 ` Anton Blanchard
2016-08-05 3:28 ` Michael Ellerman
0 siblings, 1 reply; 5+ messages in thread
From: Anton Blanchard @ 2016-08-04 5:00 UTC (permalink / raw)
To: Michael Ellerman; +Cc: herbert, linuxppc-dev
Hi Michael,
> The optimised crc32c implementation depends on VMX (aka. Altivec)
> instructions, so the kernel must be built with Altivec support in
> order for the crc32c code to build.
Thanks for that, looks good.
Acked-by: Anton Blanchard <anton@samba.org>
> Fixes: 6dd7a82cc54e ("crypto: powerpc - Add POWER8 optimised crc32c")
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> crypto/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index a9377bef25e3..84d71482bf08 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -439,7 +439,7 @@ config CRYPTO_CRC32C_INTEL
>
> config CRYPT_CRC32C_VPMSUM
> tristate "CRC32c CRC algorithm (powerpc64)"
> - depends on PPC64
> + depends on PPC64 && ALTIVEC
> select CRYPTO_HASH
> select CRC32
> help
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC
2016-08-04 5:00 ` Anton Blanchard
@ 2016-08-05 3:28 ` Michael Ellerman
2016-08-08 15:24 ` Herbert Xu
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2016-08-05 3:28 UTC (permalink / raw)
To: Anton Blanchard; +Cc: herbert, linuxppc-dev
Anton Blanchard <anton@samba.org> writes:
> Hi Michael,
>
>> The optimised crc32c implementation depends on VMX (aka. Altivec)
>> instructions, so the kernel must be built with Altivec support in
>> order for the crc32c code to build.
>
> Thanks for that, looks good.
>
> Acked-by: Anton Blanchard <anton@samba.org>
Thanks. Herbert, expecting you'll pick this up.
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC
2016-08-05 3:28 ` Michael Ellerman
@ 2016-08-08 15:24 ` Herbert Xu
2016-08-08 22:46 ` Michael Ellerman
0 siblings, 1 reply; 5+ messages in thread
From: Herbert Xu @ 2016-08-08 15:24 UTC (permalink / raw)
To: Michael Ellerman; +Cc: Anton Blanchard, linuxppc-dev
On Fri, Aug 05, 2016 at 01:28:03PM +1000, Michael Ellerman wrote:
> Anton Blanchard <anton@samba.org> writes:
>
> > Hi Michael,
> >
> >> The optimised crc32c implementation depends on VMX (aka. Altivec)
> >> instructions, so the kernel must be built with Altivec support in
> >> order for the crc32c code to build.
> >
> > Thanks for that, looks good.
> >
> > Acked-by: Anton Blanchard <anton@samba.org>
>
> Thanks. Herbert, expecting you'll pick this up.
In that case Anton can you please post it to linux-crypto?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC
2016-08-08 15:24 ` Herbert Xu
@ 2016-08-08 22:46 ` Michael Ellerman
0 siblings, 0 replies; 5+ messages in thread
From: Michael Ellerman @ 2016-08-08 22:46 UTC (permalink / raw)
To: Herbert Xu; +Cc: Anton Blanchard, linuxppc-dev
Herbert Xu <herbert@gondor.apana.org.au> writes:
> On Fri, Aug 05, 2016 at 01:28:03PM +1000, Michael Ellerman wrote:
>> Anton Blanchard <anton@samba.org> writes:
>>
>> > Hi Michael,
>> >
>> >> The optimised crc32c implementation depends on VMX (aka. Altivec)
>> >> instructions, so the kernel must be built with Altivec support in
>> >> order for the crc32c code to build.
>> >
>> > Thanks for that, looks good.
>> >
>> > Acked-by: Anton Blanchard <anton@samba.org>
>>
>> Thanks. Herbert, expecting you'll pick this up.
>
> In that case Anton can you please post it to linux-crypto?
Sorry that's my fault, will repost to linux-crypto.
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-08-08 22:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-01 10:54 [PATCH] crypto: powerpc - CRYPT_CRC32C_VPMSUM should depend on ALTIVEC Michael Ellerman
2016-08-04 5:00 ` Anton Blanchard
2016-08-05 3:28 ` Michael Ellerman
2016-08-08 15:24 ` Herbert Xu
2016-08-08 22:46 ` Michael Ellerman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).