From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3s3LC96Q6jzDqdc for ; Tue, 2 Aug 2016 12:44:53 +1000 (AEST) Message-ID: <1470105873.12584.7.camel@kernel.crashing.org> Subject: Re: MPC5200 does not boot From: Benjamin Herrenschmidt To: Michal Sojka Cc: Michael Ellerman , linuxppc-dev@lists.ozlabs.org Date: Tue, 02 Aug 2016 12:44:33 +1000 In-Reply-To: <874m74w1m7.fsf@steelpick.2x.cz> References: <874m74w1m7.fsf@steelpick.2x.cz> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2016-08-02 at 00:44 +0200, Michal Sojka wrote: > Hi Benjamin, > > the following commit causes my MPC5200 not to boot. > >     commit 9402c684613163888714df0955fa1f17142b08bf > >     Author: Benjamin Herrenschmidt >     Date:   Tue Jul 5 15:03:41 2016 +1000 >       >         powerpc: Factor do_feature_fixup calls >          >         32 and 64-bit do a similar set of calls early on, we move it all to >         a single common function to make the boot code more readable. >          >         Signed-off-by: Benjamin Herrenschmidt > >         Signed-off-by: Michael Ellerman > > I suspect that the cause will be similar as described in commit > 1cd03890ea64795e53f17a94928cca22495acb2a. Unfortunately, I don't have > much time to debug this, but I can easily test patches. Are you sure of your bisection ? Did you verify that reverting that one patch fixes it ? Because all this does is move code to a function, the code is functionally the same and called in the same place... Cheers, Ben.