From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Michal Sojka <sojkam1@fel.cvut.cz>, linuxppc-dev@lists.ozlabs.org
Subject: Re: MPC5200 does not boot
Date: Tue, 02 Aug 2016 13:18:36 +1000 [thread overview]
Message-ID: <1470107916.12584.8.camel@kernel.crashing.org> (raw)
In-Reply-To: <20160802131643.0bb9a777@roar.ozlabs.ibm.com>
On Tue, 2016-08-02 at 13:16 +1000, Nicholas Piggin wrote:
>
> Shouldn't these be PTRRELOC(spec)->cpu_features ? You are relocating
> access to the pointer word, but not the address it contains.
> identify_cpu() returns the relocated pointer which is what 32-bit
> used
> to use.
Ah indeed ! Let me check this in qemu and I'll get back to you.
Cheers,
Ben.
next prev parent reply other threads:[~2016-08-02 3:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 22:44 MPC5200 does not boot Michal Sojka
2016-08-02 2:44 ` Benjamin Herrenschmidt
2016-08-02 3:16 ` Nicholas Piggin
2016-08-02 3:18 ` Benjamin Herrenschmidt [this message]
2016-08-02 5:38 ` Benjamin Herrenschmidt
2016-08-02 5:47 ` Michal Sojka
2016-08-10 10:52 ` Michal Sojka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470107916.12584.8.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).