From: Scott Wood <oss@buserror.net>
To: Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Zhao Qiang <qiang.zhao@nxp.com>,
"David S.Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
stable@vger.kernel.org
Subject: Re: [PATCH] soc: fsl/qe: fix Oops on CPM1 (and likely CPM2)
Date: Thu, 11 Aug 2016 18:29:59 -0500 [thread overview]
Message-ID: <1470958199.25630.266.camel@buserror.net> (raw)
In-Reply-To: <20160808160858.4B9251A2452@localhost.localdomain>
On Mon, 2016-08-08 at 18:08 +0200, Christophe Leroy wrote:
> Commit 0e6e01ff694ee ("CPM/QE: use genalloc to manage CPM/QE muram")
> has changed the way muram is managed.
> genalloc uses kmalloc(), hence requires the SLAB to be up and running.
>
> On powerpc 8xx, cpm_reset() is called early during startup.
> cpm_reset() then calls cpm_muram_init() before SLAB is available,
> hence the following Oops.
>
> cpm_reset() cannot be called during initcalls because the CPM is
> needed for console
>
> This patch splits cpm_muram_init() in two parts. The first part,
> related to mappings, is kept as cpm_muram_init()
> The second part is named cpm_muram_pool_init() and is called
> the first time cpm_muram_alloc() is used
Why do you need to split it, versus calling the full cpm_muram_init() on
demand?
-Scott
next prev parent reply other threads:[~2016-08-11 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 16:08 [PATCH] soc: fsl/qe: fix Oops on CPM1 (and likely CPM2) Christophe Leroy
2016-08-11 23:29 ` Scott Wood [this message]
2016-08-12 6:25 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470958199.25630.266.camel@buserror.net \
--to=oss@buserror.net \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=qiang.zhao@nxp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).