From: Jeremy Kerr <jk@ozlabs.org>
To: Corey Minyard <minyard@acm.org>,
openipmi-developer@lists.sourceforge.net
Cc: linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 4/4] ipmi/powernv: Use dynamic device ids
Date: Mon, 12 Sep 2016 16:55:37 +0800 [thread overview]
Message-ID: <1473670537-26428-5-git-send-email-jk@ozlabs.org> (raw)
In-Reply-To: <1473670537-26428-1-git-send-email-jk@ozlabs.org>
We don't currently provide any device ID info in the SMI registration,
so use the dynamic ID infrastructure instead.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
---
drivers/char/ipmi/ipmi_powernv.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/char/ipmi/ipmi_powernv.c b/drivers/char/ipmi/ipmi_powernv.c
index 6e658aa..10e69d6 100644
--- a/drivers/char/ipmi/ipmi_powernv.c
+++ b/drivers/char/ipmi/ipmi_powernv.c
@@ -23,7 +23,6 @@
struct ipmi_smi_powernv {
u64 interface_id;
- struct ipmi_device_id ipmi_id;
ipmi_smi_t intf;
unsigned int irq;
@@ -265,9 +264,7 @@ static int ipmi_powernv_probe(struct platform_device *pdev)
goto err_unregister;
}
- /* todo: query actual ipmi_device_id */
- rc = ipmi_register_smi(&ipmi_powernv_smi_handlers, ipmi,
- &ipmi->ipmi_id, dev, 0);
+ rc = ipmi_register_smi(&ipmi_powernv_smi_handlers, ipmi, NULL, dev, 0);
if (rc) {
dev_warn(dev, "IPMI SMI registration failed (%d)\n", rc);
goto err_free_msg;
--
2.7.4
prev parent reply other threads:[~2016-09-12 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 8:55 [PATCH 0/4] ipmi: Allow dynamic device IDs Jeremy Kerr
2016-09-12 8:55 ` [PATCH 1/4] ipmi: Add a reference from BMC devices to their interfaces Jeremy Kerr
2016-09-12 8:55 ` [PATCH 2/4] ipmi: Make ipmi_demangle_device_id more generic Jeremy Kerr
2016-09-12 8:55 ` [PATCH 3/4] ipmi: allow dynamic BMC version information Jeremy Kerr
2016-09-12 16:38 ` [Openipmi-developer] " Corey Minyard
2016-09-13 10:14 ` Jeremy Kerr
2016-09-12 8:55 ` Jeremy Kerr [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473670537-26428-5-git-send-email-jk@ozlabs.org \
--to=jk@ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).