From: Joe Perches <joe@perches.com>
To: Kees Cook <keescook@chromium.org>, Colin King <colin.king@canonical.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nathan Fontenot <nfont@linux.vnet.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Rashmica Gupta <rashmicy@gmail.com>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting"
Date: Mon, 24 Oct 2016 15:20:10 -0700 [thread overview]
Message-ID: <1477347610.2111.6.camel@perches.com> (raw)
In-Reply-To: <CAGXu5j+RGsCwZ4SpnZKnoqt3zsyYPW8FdZ8vS7cRwr_L+0q2fA@mail.gmail.com>
On Mon, 2016-10-24 at 15:13 -0700, Kees Cook wrote:
> On Mon, Oct 24, 2016 at 3:02 PM, Colin King <colin.king@canonical.com> wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > trivial fix to spelling mistake in pr_debug message
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/powerpc/platforms/pseries/hotplug-cpu.c b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> > index a1b63e0..c8929cb 100644
> > --- a/arch/powerpc/platforms/pseries/hotplug-cpu.c
> > +++ b/arch/powerpc/platforms/pseries/hotplug-cpu.c
> > @@ -553,7 +553,7 @@ static ssize_t dlpar_cpu_remove(struct device_node *dn, u32 drc_index)
> > {
> > int rc;
> >
> > - pr_debug("Attemping to remove CPU %s, drc index: %x\n",
> > + pr_debug("Attempting to remove CPU %s, drc index: %x\n",
> > dn->name, drc_index);
> >
> > rc = dlpar_offline_cpu(dn);
> > --
> > 2.9.3
>
> Reviewed-by: Kees Cook <keescook@chromium.org>
>
> scripts/spelling.txt should likely get an addition for "attemping". It
> already has "attemps"...
There may not be enough of these to be useful and to my
knowledge Colin isn't fixing comments
$ grep -rP --include=*.[ch] -wi "at+emp*t?ing" * | grep -vi attempting
arch/x86/platform/uv/uv_nmi.c:/* Ping non-responding cpus attemping to force them into the NMI handler */
arch/powerpc/platforms/pseries/hotplug-cpu.c: pr_debug("Attemping to remove CPU %s, drc index: %x\n",
next prev parent reply other threads:[~2016-10-24 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 22:02 [PATCH] powerpc/pseries: fix spelling mistake: "Attemping" -> "Attempting" Colin King
2016-10-24 22:13 ` Kees Cook
2016-10-24 22:20 ` Joe Perches [this message]
2016-10-24 22:24 ` Colin Ian King
2016-10-25 14:02 ` Nathan Fontenot
-- strict thread matches above, loose matches on Subject: below --
2017-06-04 22:40 Colin King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477347610.2111.6.camel@perches.com \
--to=joe@perches.com \
--cc=benh@kernel.crashing.org \
--cc=colin.king@canonical.com \
--cc=heiko.carstens@de.ibm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nfont@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=rashmicy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).