linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: kvm-ppc@vger.kernel.org, mpe@ellerman.id.au,
	benh@kernel.crashing.org, paulus@samba.org, agraf@suse.com,
	Suraj Jitindar Singh <sjitindarsingh@gmail.com>
Subject: [PATCH 2/2] powerpc/kvm: Update kvmppc_set_arch_compat() for ISA v3.00
Date: Thu, 27 Oct 2016 17:19:29 +1100	[thread overview]
Message-ID: <1477549169-3649-3-git-send-email-sjitindarsingh@gmail.com> (raw)
In-Reply-To: <1477549169-3649-1-git-send-email-sjitindarsingh@gmail.com>

The function kvmppc_set_arch_compat() is used to determine the value of the
processor compatibility register (PCR) for a guest running in a given
compatibility mode. There is currently no support for v3.00 of the ISA.

Add support for v3.00 of the ISA which adds an ISA v2.07 compatilibity mode
to the PCR.

We also add a check to ensure the processor we are running on is capable of
emulating the chosen processor (for example a POWER7 cannot emulate a
POWER8, similarly with a POWER8 and a POWER9).

Finally the PCR value is masked based on the bits of the register which the
current processor is actually aware of.

Signed-off-by: Suraj Jitindar Singh <sjitindarsingh@gmail.com>
---
 arch/powerpc/kvm/book3s_hv.c | 30 ++++++++++++++++++++++--------
 1 file changed, 22 insertions(+), 8 deletions(-)

diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
index 3686471..f9ae3fb 100644
--- a/arch/powerpc/kvm/book3s_hv.c
+++ b/arch/powerpc/kvm/book3s_hv.c
@@ -311,24 +311,38 @@ static int kvmppc_set_arch_compat(struct kvm_vcpu *vcpu, u32 arch_compat)
 			 * If an arch bit is set in PCR, all the defined
 			 * higher-order arch bits also have to be set.
 			 */
-			pcr = PCR_ARCH_206 | PCR_ARCH_205;
+			pcr = PCR_ARCH_207 | PCR_ARCH_206 | PCR_ARCH_205;
 			break;
 		case PVR_ARCH_206:
 		case PVR_ARCH_206p:
-			pcr = PCR_ARCH_206;
+			/* Must be at least v2.06 to emulate it */
+			if (!cpu_has_feature(CPU_FTR_ARCH_206))
+				return -EINVAL;
+			pcr = PCR_ARCH_207 | PCR_ARCH_206;
 			break;
 		case PVR_ARCH_207:
+			/* Must be at least v2.07 to emulate it */
+			if (!cpu_has_feature(CPU_FTR_ARCH_207S))
+				return -EINVAL;
+			pcr = PCR_ARCH_207;
 			break;
+		case PVR_ARCH_300:
+			/* Must be at least v3.00 to emulate it */
+			if (!cpu_has_feature(CPU_FTR_ARCH_300))
+				return -EINVAL;
 		default:
 			return -EINVAL;
 		}
 
-		if (!cpu_has_feature(CPU_FTR_ARCH_207S)) {
-			/* POWER7 can't emulate POWER8 */
-			if (!(pcr & PCR_ARCH_206))
-				return -EINVAL;
-			pcr &= ~PCR_ARCH_206;
-		}
+		/*
+		 * Mask the pcr bits which the current processor knows about
+		 * v2.06 and above knows about the v2.05 compat bit
+		 * v2,07 and above knows about the v2.06 compat bit
+		 * v3.00 and above knows about the v2.07 compat bit
+		 */
+		pcr &= (cpu_has_feature(CPU_FTR_ARCH_300) << 3) |
+			(cpu_has_feature(CPU_FTR_ARCH_207S) << 2) |
+			(cpu_has_feature(CPU_FTR_ARCH_206) << 1);
 	}
 
 	spin_lock(&vc->lock);
-- 
2.5.5

  parent reply	other threads:[~2016-10-27  6:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27  6:19 [PATCH 0/2] powerpc: add support for ISA v2.07 compat level Suraj Jitindar Singh
2016-10-27  6:19 ` [PATCH 1/2] powerpc: Define new ISA v3.00 logical PVR value and PCR register value Suraj Jitindar Singh
2016-10-27  6:19 ` Suraj Jitindar Singh [this message]
2016-10-27 11:28   ` [PATCH 2/2] powerpc/kvm: Update kvmppc_set_arch_compat() for ISA v3.00 Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1477549169-3649-3-git-send-email-sjitindarsingh@gmail.com \
    --to=sjitindarsingh@gmail.com \
    --cc=agraf@suse.com \
    --cc=benh@kernel.crashing.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).