From: Yangbo Lu <yangbo.lu@nxp.com>
To: <linux-mmc@vger.kernel.org>, <ulf.hansson@linaro.org>,
Scott Wood <oss@buserror.net>, Arnd Bergmann <arnd@arndb.de>
Cc: <linuxppc-dev@lists.ozlabs.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-clk@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <iommu@lists.linux-foundation.org>,
<netdev@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Jochen Friedrich <jochen@scram.de>,
Joerg Roedel <joro@8bytes.org>,
Claudiu Manoil <claudiu.manoil@freescale.com>,
Bhupesh Sharma <bhupesh.sharma@freescale.com>,
Qiang Zhao <qiang.zhao@nxp.com>,
Kumar Gala <galak@codeaurora.org>, Leo Li <leoyang.li@nxp.com>,
Xiaobo Xie <xiaobo.xie@nxp.com>,
Minghuan Lian <minghuan.lian@nxp.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [v16, 6/7] base: soc: Check for NULL SoC device attributes
Date: Wed, 9 Nov 2016 11:14:11 +0800 [thread overview]
Message-ID: <1478661252-42439-7-git-send-email-yangbo.lu@nxp.com> (raw)
In-Reply-To: <1478661252-42439-1-git-send-email-yangbo.lu@nxp.com>
From: Geert Uytterhoeven <geert+renesas@glider.be>
If soc_device_match() is used to check the value of a specific
attribute that is not present for the current SoC, the kernel crashes
with a NULL pointer dereference.
Fix this by explicitly checking for the absence of a needed property,
and considering this a non-match.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Arnd Bergmann <arnd@arndb.de>
---
Changes for v16:
- Added this patch
---
drivers/base/soc.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/base/soc.c b/drivers/base/soc.c
index 0c5cf87..0e701e2 100644
--- a/drivers/base/soc.c
+++ b/drivers/base/soc.c
@@ -167,19 +167,23 @@ static int soc_device_match_one(struct device *dev, void *arg)
const struct soc_device_attribute *match = arg;
if (match->machine &&
- !glob_match(match->machine, soc_dev->attr->machine))
+ (!soc_dev->attr->machine ||
+ !glob_match(match->machine, soc_dev->attr->machine)))
return 0;
if (match->family &&
- !glob_match(match->family, soc_dev->attr->family))
+ (!soc_dev->attr->family ||
+ !glob_match(match->family, soc_dev->attr->family)))
return 0;
if (match->revision &&
- !glob_match(match->revision, soc_dev->attr->revision))
+ (!soc_dev->attr->revision ||
+ !glob_match(match->revision, soc_dev->attr->revision)))
return 0;
if (match->soc_id &&
- !glob_match(match->soc_id, soc_dev->attr->soc_id))
+ (!soc_dev->attr->soc_id ||
+ !glob_match(match->soc_id, soc_dev->attr->soc_id)))
return 0;
return 1;
--
2.1.0.27.g96db324
next prev parent reply other threads:[~2016-11-09 3:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 3:14 [v16, 0/7] Fix eSDHC host version register bug Yangbo Lu
2016-11-09 3:14 ` [v16, 1/7] ARM64: dts: ls2080a: add device configuration node Yangbo Lu
2016-11-09 3:14 ` [v16, 2/7] dt: bindings: move guts devicetree doc out of powerpc directory Yangbo Lu
2016-11-09 3:14 ` [v16, 3/7] soc: fsl: add GUTS driver for QorIQ platforms Yangbo Lu
2016-11-09 3:14 ` [v16, 4/7] MAINTAINERS: add entry for Freescale SoC drivers Yangbo Lu
2016-11-09 3:14 ` [v16, 5/7] base: soc: introduce soc_device_match() interface Yangbo Lu
2016-11-09 3:14 ` Yangbo Lu [this message]
2016-11-09 3:14 ` [v16, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0 Yangbo Lu
2016-11-09 9:18 ` [v16, 0/7] Fix eSDHC host version register bug Wolfram Sang
2016-11-09 18:27 ` Ulf Hansson
2016-11-10 3:55 ` Scott Wood
2016-11-10 4:06 ` Y.B. Lu
2016-11-10 4:11 ` Y.B. Lu
2016-11-10 5:17 ` Scott Wood
2016-11-10 9:26 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478661252-42439-7-git-send-email-yangbo.lu@nxp.com \
--to=yangbo.lu@nxp.com \
--cc=arnd@arndb.de \
--cc=bhupesh.sharma@freescale.com \
--cc=claudiu.manoil@freescale.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jochen@scram.de \
--cc=joro@8bytes.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=minghuan.lian@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=oss@buserror.net \
--cc=qiang.zhao@nxp.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=xiaobo.xie@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).