From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from host.buserror.net (host.buserror.net [209.198.135.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tDq2Z2kGNzDvLZ for ; Thu, 10 Nov 2016 14:55:34 +1100 (AEDT) Message-ID: <1478750114.21746.4.camel@buserror.net> From: Scott Wood To: Ulf Hansson , Yangbo Lu Cc: linux-mmc , Arnd Bergmann , "linuxppc-dev@lists.ozlabs.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-clk , iommu@lists.linux-foundation.org, netdev@vger.kernel.org, Greg Kroah-Hartman , Mark Rutland , Rob Herring , Russell King , Jochen Friedrich , Joerg Roedel , Claudiu Manoil , Bhupesh Sharma , Qiang Zhao , Kumar Gala , Leo Li , Xiaobo Xie , Minghuan Lian Date: Wed, 09 Nov 2016 21:55:14 -0600 In-Reply-To: References: <1478661252-42439-1-git-send-email-yangbo.lu@nxp.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Subject: Re: [v16, 0/7] Fix eSDHC host version register bug List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2016-11-09 at 19:27 +0100, Ulf Hansson wrote: > - i2c-list > > On 9 November 2016 at 04:14, Yangbo Lu wrote: > > > > This patchset is used to fix a host version register bug in the T4240- > > R1.0-R2.0 > > eSDHC controller. To match the SoC version and revision, 15 previous > > version > > patchsets had tried many methods but all of them were rejected by > > reviewers. > > Such as > >         - dts compatible method > >         - syscon method > >         - ifdef PPC method > >         - GUTS driver getting SVR method > > Anrd suggested a soc_device_match method in v10, and this is the only > > available > > method left now. This v11 patchset introduces the soc_device_match > > interface in > > soc driver. > > > > The first four patches of Yangbo are to add the GUTS driver. This is used > > to > > register a soc device which contain soc version and revision information. > > The other three patches introduce the soc_device_match method in soc > > driver > > and apply it on esdhc driver to fix this bug. > > > > --- > > Changes for v15: > >         - Dropped patch 'dt: bindings: update Freescale DCFG compatible' > >           since the work had been done by below patch on ShawnGuo's linux > > tree. > >           'dt-bindings: fsl: add LS1043A/LS1046A/LS2080A compatible for > > SCFG > >            and DCFG' > >         - Fixed error code issue in guts driver > > Changes for v16: > >         - Dropped patch 'powerpc/fsl: move mpc85xx.h to include/linux/fsl' > >         - Added a bug-fix patch from Geert > > --- > > > > Arnd Bergmann (1): > >   base: soc: introduce soc_device_match() interface > > > > Geert Uytterhoeven (1): > >   base: soc: Check for NULL SoC device attributes > > > > Yangbo Lu (5): > >   ARM64: dts: ls2080a: add device configuration node > >   dt: bindings: move guts devicetree doc out of powerpc directory > >   soc: fsl: add GUTS driver for QorIQ platforms > >   MAINTAINERS: add entry for Freescale SoC drivers > >   mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0 > > > >  .../bindings/{powerpc => soc}/fsl/guts.txt         |   3 + > >  MAINTAINERS                                        |  11 +- > >  arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi     |   6 + > >  drivers/base/Kconfig                               |   1 + > >  drivers/base/soc.c                                 |  70 ++++++ > >  drivers/mmc/host/Kconfig                           |   1 + > >  drivers/mmc/host/sdhci-of-esdhc.c                  |  20 ++ > >  drivers/soc/Kconfig                                |   3 +- > >  drivers/soc/fsl/Kconfig                            |  18 ++ > >  drivers/soc/fsl/Makefile                           |   1 + > >  drivers/soc/fsl/guts.c                             | 236 > > +++++++++++++++++++++ > >  include/linux/fsl/guts.h                           | 125 ++++++----- > >  include/linux/sys_soc.h                            |   3 + > >  13 files changed, 447 insertions(+), 51 deletions(-) > >  rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/guts.txt > > (91%) > >  create mode 100644 drivers/soc/fsl/Kconfig > >  create mode 100644 drivers/soc/fsl/guts.c > > > > -- > > 2.1.0.27.g96db324 > > > Thanks, applied on my mmc tree for next! > > I noticed that some DT compatibles weren't documented, according to > checkpatch. Please fix that asap! They are documented, in fsl/guts.txt (the file moved in patch 2/7): >  - compatible : Should define the compatible device type for >    global-utilities. >    Possible compatibles: >         "fsl,qoriq-device-config-1.0" >         "fsl,qoriq-device-config-2.0" >         "fsl,-device-config" >         "fsl,-guts" Checkpatch doesn't understand compatibles defined in such a way. -Scott