From: Ian Munsie <imunsie@au1.ibm.com>
To: "andrew.donnellan" <andrew.donnellan@au1.ibm.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
fbarrat <fbarrat@linux.vnet.ibm.com>
Subject: Re: [PATCH] cxl: fix coccinelle warnings
Date: Wed, 23 Nov 2016 18:32:23 +1100 [thread overview]
Message-ID: <1479886310-sup-1768@x230.ozlabs.ibm.com> (raw)
In-Reply-To: <72ee4e44-af7d-2351-91ae-4f3f28999bce@au1.ibm.com>
Excerpts from andrew.donnellan's message of 2016-11-23 18:06:59 +1100:
> On 23/11/16 17:49, Ian Munsie wrote:
> > Most of these look fine
> >
> >> - return debugfs_create_file(name, mode, parent, (void __force *)value, &fops_io_x64);
> >> + return debugfs_create_file_unsafe(name, mode, parent,
> >> + (void __force *)value, &fops_io_x64);
> >
> > Just wondering what this one is about?
>
> See explanation at https://lkml.org/lkml/2016/3/6/75 - when we use
> DEFINE_DEBUGFS_ATTRIBUTE() rather than DEFINE_SIMPLE_ATTRIBUTE(), we
> don't need the "lifetime managing proxy" that debugfs_create_file() sets up.
>
> coccinelle proposed that change based on
> scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
Thanks, that makes sense :)
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
next prev parent reply other threads:[~2016-11-23 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 10:13 [PATCH] cxl: fix coccinelle warnings Andrew Donnellan
2016-11-22 11:32 ` Frederic Barrat
2016-11-22 17:03 ` Matthew R. Ochs
2016-11-23 6:49 ` Ian Munsie
2016-11-23 7:06 ` Andrew Donnellan
2016-11-23 7:32 ` Ian Munsie [this message]
2016-11-25 0:04 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479886310-sup-1768@x230.ozlabs.ibm.com \
--to=imunsie@au1.ibm.com \
--cc=andrew.donnellan@au1.ibm.com \
--cc=fbarrat@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).