From: Russell Currey <ruscur@russell.cc>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
linuxppc-dev@lists.ozlabs.org, gwshan@linux.vnet.ibm.com
Cc: ukrishn@linux.vnet.ibm.com, pradghos@in.ibm.com
Subject: Re: [PATCH] powerpc/eeh: fix deadlock when PE frozen state can't be cleared
Date: Thu, 01 Dec 2016 11:27:39 +1100 [thread overview]
Message-ID: <1480552059.5964.1.camel@russell.cc> (raw)
In-Reply-To: <20161201002305.14591-1-andrew.donnellan@au1.ibm.com>
On Thu, 2016-12-01 at 11:23 +1100, Andrew Donnellan wrote:
> In eeh_reset_device(), we take the pci_rescan_remove_lock immediately after
> after we call eeh_reset_pe() to reset the PCI controller. We then call
> eeh_clear_pe_frozen_state(), which can return an error. In this case, we
> bail out of eeh_reset_device() without calling pci_unlock_rescan_remove().
>
> Add a call to pci_unlock_rescan_remove() in the eeh_clear_pe_frozen_state()
> error path so that we don't cause a deadlock later on.
>
> Reported-by: Pradipta Ghosh <pradghos@in.ibm.com>
> Fixes: 78954700631f ("powerpc/eeh: Avoid I/O access during PE reset")
> Cc: stable@vger.kernel.org
> Signed-off-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
> ---
Locking in this function is such a mess, we (I) should revisit it at some point.
Acked-by: Russell Currey <ruscur@russell.cc>
next prev parent reply other threads:[~2016-12-01 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-01 0:23 [PATCH] powerpc/eeh: fix deadlock when PE frozen state can't be cleared Andrew Donnellan
2016-12-01 0:27 ` Russell Currey [this message]
2016-12-03 11:31 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480552059.5964.1.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=andrew.donnellan@au1.ibm.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pradghos@in.ibm.com \
--cc=ukrishn@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).