* Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub
2016-12-16 6:14 [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub Kamalesh Babulal
@ 2016-12-16 9:21 ` Balbir Singh
2016-12-16 10:25 ` Petr Mladek
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Balbir Singh @ 2016-12-16 9:21 UTC (permalink / raw)
To: Kamalesh Babulal, Michael Ellerman, Jessica Yu
Cc: Josh Poimboeuf, Jiri Kosina, Miroslav Benes, Petr Mladek,
linuxppc-dev, live-patching, linux-kernel
On 16/12/16 17:14, Kamalesh Babulal wrote:
> commit 425595a7fc20 ("livepatch: reuse module loader code
> to write relocations") offloads livepatch module relocation
> write to arch specific module loader code.
>
> Remove unused klp_write_module_reloc() function stub.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> arch/powerpc/include/asm/livepatch.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h
> index a402f7f..47a03b9 100644
> --- a/arch/powerpc/include/asm/livepatch.h
> +++ b/arch/powerpc/include/asm/livepatch.h
> @@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void)
> return 0;
> }
>
> -static inline int klp_write_module_reloc(struct module *mod, unsigned long
> - type, unsigned long loc, unsigned long value)
> -{
> - /* This requires infrastructure changes; we need the loadinfos. */
> - return -ENOSYS;
> -}
> -
Makes sense
Acked-by: Balbir Singh <bsingharora@gmail.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub
2016-12-16 6:14 [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub Kamalesh Babulal
2016-12-16 9:21 ` Balbir Singh
@ 2016-12-16 10:25 ` Petr Mladek
2016-12-16 15:18 ` Josh Poimboeuf
2016-12-19 10:15 ` Jiri Kosina
3 siblings, 0 replies; 5+ messages in thread
From: Petr Mladek @ 2016-12-16 10:25 UTC (permalink / raw)
To: Kamalesh Babulal
Cc: Michael Ellerman, Jessica Yu, Josh Poimboeuf, Jiri Kosina,
Miroslav Benes, linuxppc-dev, live-patching, linux-kernel,
Balbir Singh
On Fri 2016-12-16 11:44:24, Kamalesh Babulal wrote:
> commit 425595a7fc20 ("livepatch: reuse module loader code
> to write relocations") offloads livepatch module relocation
> write to arch specific module loader code.
>
> Remove unused klp_write_module_reloc() function stub.
Yup, the function is not longer used.
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Best Regards,
Petr
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub
2016-12-16 6:14 [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub Kamalesh Babulal
2016-12-16 9:21 ` Balbir Singh
2016-12-16 10:25 ` Petr Mladek
@ 2016-12-16 15:18 ` Josh Poimboeuf
2016-12-19 10:15 ` Jiri Kosina
3 siblings, 0 replies; 5+ messages in thread
From: Josh Poimboeuf @ 2016-12-16 15:18 UTC (permalink / raw)
To: Kamalesh Babulal
Cc: Michael Ellerman, Jessica Yu, Jiri Kosina, Miroslav Benes,
Petr Mladek, linuxppc-dev, live-patching, linux-kernel,
Balbir Singh
On Fri, Dec 16, 2016 at 11:44:24AM +0530, Kamalesh Babulal wrote:
> commit 425595a7fc20 ("livepatch: reuse module loader code
> to write relocations") offloads livepatch module relocation
> write to arch specific module loader code.
>
> Remove unused klp_write_module_reloc() function stub.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub
2016-12-16 6:14 [PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub Kamalesh Babulal
` (2 preceding siblings ...)
2016-12-16 15:18 ` Josh Poimboeuf
@ 2016-12-19 10:15 ` Jiri Kosina
3 siblings, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2016-12-19 10:15 UTC (permalink / raw)
To: Kamalesh Babulal
Cc: Michael Ellerman, Jessica Yu, Josh Poimboeuf, Miroslav Benes,
Petr Mladek, linuxppc-dev, live-patching, linux-kernel,
Balbir Singh
On Fri, 16 Dec 2016, Kamalesh Babulal wrote:
> commit 425595a7fc20 ("livepatch: reuse module loader code
> to write relocations") offloads livepatch module relocation
> write to arch specific module loader code.
>
> Remove unused klp_write_module_reloc() function stub.
>
> Signed-off-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> arch/powerpc/include/asm/livepatch.h | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/arch/powerpc/include/asm/livepatch.h b/arch/powerpc/include/asm/livepatch.h
> index a402f7f..47a03b9 100644
> --- a/arch/powerpc/include/asm/livepatch.h
> +++ b/arch/powerpc/include/asm/livepatch.h
> @@ -28,13 +28,6 @@ static inline int klp_check_compiler_support(void)
> return 0;
> }
>
> -static inline int klp_write_module_reloc(struct module *mod, unsigned long
> - type, unsigned long loc, unsigned long value)
> -{
> - /* This requires infrastructure changes; we need the loadinfos. */
> - return -ENOSYS;
> -}
> -
> static inline void klp_arch_set_pc(struct pt_regs *regs, unsigned long ip)
> {
> regs->nip = ip;
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread