From: Michael Neuling <mikey@neuling.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
Chris Smart <csmart@ozlabs.au.ibm.com>,
Christophe Leroy <christophe.leroy@c-s.fr>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/mm/hugetlb: Don't panic if we don't find the default huge page size
Date: Wed, 04 Jan 2017 11:18:57 +1100 [thread overview]
Message-ID: <1483489137.6577.11.camel@neuling.org> (raw)
In-Reply-To: <20161213140411.20633-1-aneesh.kumar@linux.vnet.ibm.com>
On Tue, 2016-12-13 at 19:34 +0530, Aneesh Kumar K.V wrote:
> generic hugetlbfs can handle that condition correctly. With HPAGE_SHIFT =
=3D 0
> we get
> [0.241333] hugetlbfs: disabling because there are no supported hugepage s=
izes
>=20
> bash-4.2# echo 30 > /proc/sys/vm/nr_hugepages
> bash: echo: write error: Operation not supported
>=20
> Fixes: "powerpc: get hugetlbpage handling more generic"
> Reported-by: Chris Smart <csmart@ozlabs.au.ibm.com>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Acked-By: Michael Neuling <mikey@neuling.org>
> ---
> =C2=A0arch/powerpc/mm/hugetlbpage.c | 3 ---
> =C2=A01 file changed, 3 deletions(-)
>=20
> diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.=
c
> index 289df38fb7e0..e46bbd716832 100644
> --- a/arch/powerpc/mm/hugetlbpage.c
> +++ b/arch/powerpc/mm/hugetlbpage.c
> @@ -852,9 +852,6 @@ static int __init hugetlbpage_init(void)
> =C2=A0 else if (mmu_psize_defs[MMU_PAGE_2M].shift)
> =C2=A0 HPAGE_SHIFT =3D mmu_psize_defs[MMU_PAGE_2M].shift;
> =C2=A0#endif
> - else
> - panic("%s: Unable to set default huge page size\n",
> __func__);
> -
> =C2=A0 return 0;
> =C2=A0}
> =C2=A0
next prev parent reply other threads:[~2017-01-04 0:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 14:04 [PATCH] powerpc/mm/hugetlb: Don't panic if we don't find the default huge page size Aneesh Kumar K.V
2017-01-04 0:18 ` Michael Neuling [this message]
2017-01-16 6:55 ` Anshuman Khandual
2017-01-16 16:42 ` Aneesh Kumar K.V
2017-01-18 12:10 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483489137.6577.11.camel@neuling.org \
--to=mikey@neuling.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=csmart@ozlabs.au.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).