From: Bhumika Goyal <bhumirks@gmail.com>
To: julia.lawall@lip6.fr, tyreld@linux.vnet.ibm.com,
benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Cc: Bhumika Goyal <bhumirks@gmail.com>
Subject: [PATCH] scsi: ibmvscsi: constify dev_pm_ops structures
Date: Sun, 15 Jan 2017 10:23:17 +0530 [thread overview]
Message-ID: <1484455997-24400-1-git-send-email-bhumirks@gmail.com> (raw)
Declare dev_pm_ops structures as const as they are only stored in the pm
field of a vio_driver structure. This field is of type const, so
dev_pm_ops structures having similar properties can be declared const.
Done using Coccinelle:
@r1 disable optional_qualifier@
identifier i;
position p;
@@
static struct dev_pm_ops i@p={...};
@ok@
identifier r1.i;
position p;
struct vio_driver x;
@@
x.pm=&i@p;
@bad@
position p!={r1.p,ok.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct dev_pm_ops i;
File sizes after cross compiling the .o files for powerpc architecture.
File size before:
text data bss dec hex filename
57893 5665 20 63578 f85a drivers/scsi/ibmvscsi/ibmvfc.o
File size after:
text data bss dec hex filename
58077 5481 20 63578 f85a drivers/scsi/ibmvscsi/ibmvfc.o
File size before:
text data bss dec hex filenam
20990 2816 80 23886 5d4e drivers/scsi/ibmvscsi/ibmvscsi.o
File size after:
text data bss dec hex filename
21174 2632 80 23886 5d4e drivers/scsi/ibmvscsi/ibmvscsi.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
drivers/scsi/ibmvscsi/ibmvscsi.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index 78b72c2..1e1b343 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -4940,7 +4940,7 @@ static unsigned long ibmvfc_get_desired_dma(struct vio_dev *vdev)
};
MODULE_DEVICE_TABLE(vio, ibmvfc_device_table);
-static struct dev_pm_ops ibmvfc_pm_ops = {
+static const struct dev_pm_ops ibmvfc_pm_ops = {
.resume = ibmvfc_resume
};
diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c
index 50cd011..b94e7b1 100644
--- a/drivers/scsi/ibmvscsi/ibmvscsi.c
+++ b/drivers/scsi/ibmvscsi/ibmvscsi.c
@@ -2335,7 +2335,7 @@ static int ibmvscsi_resume(struct device *dev)
};
MODULE_DEVICE_TABLE(vio, ibmvscsi_device_table);
-static struct dev_pm_ops ibmvscsi_pm_ops = {
+static const struct dev_pm_ops ibmvscsi_pm_ops = {
.resume = ibmvscsi_resume
};
--
1.9.1
next reply other threads:[~2017-01-15 4:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 4:53 Bhumika Goyal [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-06-29 7:43 [PATCH] scsi: ibmvscsi: constify dev_pm_ops structures Arvind Yadav
2017-06-29 22:38 ` Tyrel Datwyler
2017-07-01 21:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484455997-24400-1-git-send-email-bhumirks@gmail.com \
--to=bhumirks@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=martin.petersen@oracle.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).