From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-kernel@vger.kernel.org, mpe@ellerman.id.au, jeyu@redhat.com
Cc: rusty@rustcorp.com.au, suzuki.poulose@arm.com,
will.deacon@arm.com, akpm@linux-foundation.org,
benh@kernel.crashing.org, paulus@samba.org, arnd@arndb.de,
torvalds@linux-foundation.org, viro@zeniv.linux.org.uk,
linuxppc-dev@lists.ozlabs.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v4 0/3] modversions: Fix CRC mangling under CONFIG_RELOCATABLE=y
Date: Tue, 17 Jan 2017 19:26:10 +0000 [thread overview]
Message-ID: <1484681173-11644-1-git-send-email-ard.biesheuvel@linaro.org> (raw)
This series is a followup to the single patch 'modversions: treat symbol
CRCs as 32 bit quantities on 64 bit archs', of which three versions have
been sent out so far [0][1][2]
Given the recent issues regarding modversions, I have added some more
people to cc this time.
As pointed out by Michael, GNU ld behaves a bit differently between arm64
and PowerPC64, and where the former gets rid of all runtime relocations
related to CRCs, the latter is not as easily convinced.
Patch #1 fixes the issue where CRCs are corrupted by the runtime relocation
routines for 32-bit PowerPC, for which the original fix was effectively
reverted by commit 0e0ed6406e61 ("powerpc/modules: Module CRC relocation fix
causes perf issues")
Patch #2 adds handling of R_PPC64_ADDR32 relocations against the NULL .dynsym
symbol entry to the PPC64 runtime relocation routines, so it is prepared to
deal with CRCs being emitted as 32-bit quantities.
Patch #3 is the original patch from the v1 and v2 submissions.
Changes since v3:
- rebased onto v4.10-rc
- add Suzuki's ack to patch #1
- update patch #2 to work around the binutils-powerpc behavior to only
account for R_PPC64_RELATIVE relocations in the RELACOUNT entry in
.dynamic
Changes since v2:
- added #1 and #2
- updated #3 to deal with CRC entries being emitted from assembler
- added Rusty's ack (#3)
Branch can be found here:
https://git.kernel.org/cgit/linux/kernel/git/ardb/linux.git/log/?h=kcrctab-reloc
[0] http://marc.info/?l=linux-kernel&m=147652300207369&w=2
[1] http://marc.info/?l=linux-kernel&m=147695629614409&w=2
[2] http://marc.info/?l=linux-kernel&m=147758564705776&w=2
Ard Biesheuvel (3):
powerpc/reloc32: fix corrupted modversion CRCs
powerpc/reloc64: add support for 32-bit CRC pseudo-symbols
modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs
arch/powerpc/include/asm/module.h | 4 --
arch/powerpc/kernel/module_64.c | 8 ---
arch/powerpc/kernel/reloc_32.S | 36 ++++++++++--
arch/powerpc/kernel/reloc_64.S | 60 ++++++++++++--------
arch/powerpc/kernel/vmlinux.lds.S | 1 +
arch/powerpc/relocs_check.sh | 5 +-
include/asm-generic/export.h | 7 +--
include/linux/export.h | 8 +++
include/linux/module.h | 14 ++---
kernel/module.c | 47 ++++++---------
10 files changed, 105 insertions(+), 85 deletions(-)
--
2.7.4
next reply other threads:[~2017-01-17 19:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 19:26 Ard Biesheuvel [this message]
2017-01-17 19:26 ` [PATCH v4 1/3] powerpc/reloc32: fix corrupted modversion CRCs Ard Biesheuvel
2017-01-17 19:26 ` [PATCH v4 2/3] powerpc/reloc64: add support for 32-bit CRC pseudo-symbols Ard Biesheuvel
2017-01-18 15:30 ` Ard Biesheuvel
2017-01-17 19:26 ` [PATCH v4 3/3] modversions: treat symbol CRCs as 32 bit quantities on 64 bit archs Ard Biesheuvel
2017-01-17 23:47 ` Linus Torvalds
2017-01-18 11:37 ` Ard Biesheuvel
2017-01-18 13:52 ` Ard Biesheuvel
2017-01-18 18:27 ` Linus Torvalds
2017-01-18 18:35 ` Linus Torvalds
2017-01-18 22:37 ` Ard Biesheuvel
2017-01-19 0:15 ` Linus Torvalds
2017-01-19 9:22 ` Ard Biesheuvel
2017-01-19 17:24 ` Linus Torvalds
2017-01-20 12:21 ` Ard Biesheuvel
2017-01-19 17:01 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484681173-11644-1-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=jeyu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rusty@rustcorp.com.au \
--cc=suzuki.poulose@arm.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).