linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
To: netdev@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, wvoigt@us.ibm.com,
	nfont@linux.vnet.ibm.com, jallen@linux.vnet.ibm.com,
	tlfalcon@linux.vnet.ibm.com
Subject: [PATCH net 5/5] ibmvnic: init completion struct before requesting long term mapped buffers
Date: Wed, 25 Jan 2017 15:02:23 -0600	[thread overview]
Message-ID: <1485378143-5084-5-git-send-email-tlfalcon@linux.vnet.ibm.com> (raw)
In-Reply-To: <1485378143-5084-1-git-send-email-tlfalcon@linux.vnet.ibm.com>

Initialize this completion structure before requesting that
a buffer be long-term mapped . This fix resolves a bug where firmware
sends a response before the structure is initialized.

Signed-off-by: John Allen <jallen@linux.vnet.ibm.com>
Signed-off-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Signed-off-by: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index ec6c5fe..d1ffc61 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -189,9 +189,9 @@ static int alloc_long_term_buff(struct ibmvnic_adapter *adapter,
 	}
 	ltb->map_id = adapter->map_id;
 	adapter->map_id++;
+	init_completion(&adapter->fw_done);
 	send_request_map(adapter, ltb->addr,
 			 ltb->size, ltb->map_id);
-	init_completion(&adapter->fw_done);
 	wait_for_completion(&adapter->fw_done);
 	return 0;
 }
-- 
1.8.3.1

  parent reply	other threads:[~2017-01-25 21:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-25 21:02 [PATCH net 1/5] ibmvnic: harden interrupt handler Thomas Falcon
2017-01-25 21:02 ` [PATCH net 2/5] ibmvnic: Fix MTU settings Thomas Falcon
2017-01-26  4:05   ` David Miller
2017-01-26 16:44     ` Thomas Falcon
2017-01-26 17:56       ` David Miller
2017-01-25 21:02 ` [PATCH net 3/5] ibmvnic: Fix endian error when requesting device capabilites Thomas Falcon
2017-01-25 21:02 ` [PATCH net 4/5] ibmvnic: Fix endian errors in error reporting output Thomas Falcon
2017-01-25 21:02 ` Thomas Falcon [this message]
2017-01-26  4:04 ` [PATCH net 1/5] ibmvnic: harden interrupt handler David Miller
2017-01-26 16:44   ` Thomas Falcon
2017-01-26 17:56     ` David Miller
2017-01-26 18:57       ` Thomas Falcon
2017-01-26 18:28 ` Stephen Hemminger
2017-01-26 19:05   ` Thomas Falcon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485378143-5084-5-git-send-email-tlfalcon@linux.vnet.ibm.com \
    --to=tlfalcon@linux.vnet.ibm.com \
    --cc=jallen@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=netdev@vger.kernel.org \
    --cc=nfont@linux.vnet.ibm.com \
    --cc=wvoigt@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).