* [PATCH] Remove extra include in HVC console tty framework
@ 2017-01-30 22:57 Sergio Valverde
2017-01-31 5:23 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Sergio Valverde @ 2017-01-30 22:57 UTC (permalink / raw)
To: linuxppc-dev, rsa, gregkh; +Cc: trivial, Sergio Valverde
From: Sergio Valverde <vlvrdv@gmail.com>
An extra "init.h" include is found in the HVC console code.
While the code works as it is right now, it is a defect nevertheless.
As such, the extra line is deleted.
Signed-off-by: Sergio Valverde <vlvrdv@gmail.com>
---
drivers/tty/hvc/hvc_console.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index 9b5c0fb..b19ae36 100644
--- a/drivers/tty/hvc/hvc_console.c
+++ b/drivers/tty/hvc/hvc_console.c
@@ -29,7 +29,6 @@
#include <linux/kernel.h>
#include <linux/kthread.h>
#include <linux/list.h>
-#include <linux/init.h>
#include <linux/major.h>
#include <linux/atomic.h>
#include <linux/sysrq.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove extra include in HVC console tty framework
2017-01-30 22:57 [PATCH] Remove extra include in HVC console tty framework Sergio Valverde
@ 2017-01-31 5:23 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2017-01-31 5:23 UTC (permalink / raw)
To: Sergio Valverde; +Cc: linuxppc-dev, rsa, trivial
On Mon, Jan 30, 2017 at 04:57:23PM -0600, Sergio Valverde wrote:
> From: Sergio Valverde <vlvrdv@gmail.com>
>
> An extra "init.h" include is found in the HVC console code.
>
> While the code works as it is right now, it is a defect nevertheless.
> As such, the extra line is deleted.
It's not a "defect" as it's not wrong. It's just an annoyance. This
whole sentence should probably be removed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-31 5:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-30 22:57 [PATCH] Remove extra include in HVC console tty framework Sergio Valverde
2017-01-31 5:23 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).