linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Shailendra Singh <shailendras@nvidia.com>
To: <linuxppc-dev@lists.ozlabs.org>, <jk@ozlabs.org>,
	<shailendras@nvidia.com>, <apopple@au1.ibm.com>,
	<balbirs@au1.ibm.com>, <aritger@nvidia.com>,
	<jhubbard@nvidia.com>, <scheung@nvidia.com>,
	<amanjunatha@nvidia.com>, <jmckenna@nvidia.com>
Subject: [PATCH] powerpc: Fix inconsistent of_node_to_nid EXPORT_SYMBOL handling
Date: Wed, 1 Feb 2017 14:52:42 -0800	[thread overview]
Message-ID: <1485989562-16741-1-git-send-email-shailendras@nvidia.com> (raw)

The generic implementation of of_node_to_nid is EXPORT_SYMBOL.

The powerpc implementation added by following commit is EXPORT_SYMBOL_GPL.
commit 953039c8df7b ("[PATCH] powerpc: Allow devices to register with numa
topology")

This creates an inconsistency for of_node_to_nid callers across
architectures.

Update the powerpc implementation to be exported consistently with the
generic implementation.

Signed-off-by: Shailendra Singh <shailendras@nvidia.com>

Reviewed-by: Andy Ritger <aritger@nvidia.com>
---
 arch/powerpc/mm/numa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index b1099cb2f393..8aa4ca3c84c9 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -290,7 +290,7 @@ int of_node_to_nid(struct device_node *device)
 
 	return nid;
 }
-EXPORT_SYMBOL_GPL(of_node_to_nid);
+EXPORT_SYMBOL(of_node_to_nid);
 
 static int __init find_min_common_depth(void)
 {
-- 
2.4.11

             reply	other threads:[~2017-02-01 22:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 22:52 Shailendra Singh [this message]
2017-02-09 12:18 ` [PATCH] powerpc: Fix inconsistent of_node_to_nid EXPORT_SYMBOL handling Michael Ellerman
2017-02-09 21:15   ` Shailendra Singh
2017-02-14 12:40 ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1485989562-16741-1-git-send-email-shailendras@nvidia.com \
    --to=shailendras@nvidia.com \
    --cc=amanjunatha@nvidia.com \
    --cc=apopple@au1.ibm.com \
    --cc=aritger@nvidia.com \
    --cc=balbirs@au1.ibm.com \
    --cc=jhubbard@nvidia.com \
    --cc=jk@ozlabs.org \
    --cc=jmckenna@nvidia.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=scheung@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).