From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
jeyu@redhat.com, rusty@rustcorp.com.au, mmarek@suse.com,
mpe@ellerman.id.au
Cc: torvalds@linux-foundation.org, arnd@arndb.de,
viro@zeniv.linux.org.uk, linux-arm-kernel@lists.infradead.org,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: [PATCH v5 3/3] module: unify absolute krctab definitions for 32-bit and 64-bit
Date: Fri, 3 Feb 2017 09:54:07 +0000 [thread overview]
Message-ID: <1486115647-27680-4-git-send-email-ard.biesheuvel@linaro.org> (raw)
In-Reply-To: <1486115647-27680-1-git-send-email-ard.biesheuvel@linaro.org>
The previous patch introduced a separate inline asm version of the
krcrctab declaration template for use with 64-bit architectures, which
cannot refer to ELF symbols using 32-bit quantities. This declaration
should be equivalent to the C one for 32-bit architectures, but this
needs to be checked first, so unify them in a separate patch.
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
... which can simply be dropped if it turns out to break anything.
include/linux/export.h | 7 -------
1 file changed, 7 deletions(-)
diff --git a/include/linux/export.h b/include/linux/export.h
index 7473fba6a60c..1a1dfdb2a5c6 100644
--- a/include/linux/export.h
+++ b/include/linux/export.h
@@ -49,13 +49,6 @@ extern struct module __this_module;
" .weak " VMLINUX_SYMBOL_STR(__crc_##sym) " \n" \
" .long " VMLINUX_SYMBOL_STR(__crc_##sym) " - . \n" \
" .previous \n");
-#elif !defined(CONFIG_64BIT)
-#define __CRC_SYMBOL(sym, sec) \
- extern __visible void *__crc_##sym __attribute__((weak)); \
- static const unsigned long __kcrctab_##sym \
- __used \
- __attribute__((section("___kcrctab" sec "+" #sym), used)) \
- = (unsigned long) &__crc_##sym;
#else
#define __CRC_SYMBOL(sym, sec) \
asm(" .section \"___kcrctab" sec "+" #sym "\", \"a\" \n" \
--
2.7.4
next prev parent reply other threads:[~2017-02-03 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-03 9:54 [PATCH v5 0/3] modversions: redefine kcrctab entries as 32-bit values Ard Biesheuvel
2017-02-03 9:54 ` [PATCH v5 1/3] kbuild: modversions: add infrastructure for emitting relative CRCs Ard Biesheuvel
2017-02-03 9:54 ` [PATCH v5 2/3] modversions: treat symbol CRCs as 32 bit quantities Ard Biesheuvel
2017-02-03 9:54 ` Ard Biesheuvel [this message]
2017-02-03 16:30 ` [PATCH v5 0/3] modversions: redefine kcrctab entries as 32-bit values Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486115647-27680-4-git-send-email-ard.biesheuvel@linaro.org \
--to=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=jeyu@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mmarek@suse.com \
--cc=mpe@ellerman.id.au \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).