[PATCH] powerpc/mm: Fix typo in set_pte_at()

[PATCH] powerpc/mm: Fix typo in set_pte_at()

[Gavin Shan]

This fixes the typo about the _PAGE_PTE in set_pte_at() by changing
"tryint" to "trying to".

Fixes: 6a119eae942 ("powerpc/mm: Add a _PAGE_PTE bit")
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
---
 arch/powerpc/mm/pgtable.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
index cb39c8b..a03ff3d 100644
--- a/arch/powerpc/mm/pgtable.c
+++ b/arch/powerpc/mm/pgtable.c
@@ -193,9 +193,7 @@ void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep,
 	 */
 	VM_WARN_ON(pte_present(*ptep) && !pte_protnone(*ptep));
 
-	/*
-	 * Add the pte bit when tryint set a pte
-	 */
+	/* Add the pte bit when trying to set a pte */
 	pte = __pte(pte_val(pte) | _PAGE_PTE);
 
 	/* Note: mm->context.id might not yet have been assigned as
-- 
2.7.4

Re: [PATCH] powerpc/mm: Fix typo in set_pte_at()

[Aneesh Kumar K.V]

Gavin Shan <gwshan@linux.vnet.ibm.com> writes:

> This fixes the typo about the _PAGE_PTE in set_pte_at() by changing
> "tryint" to "trying to".
>
> Fixes: 6a119eae942 ("powerpc/mm: Add a _PAGE_PTE bit")

I guess this is not needed. We add that when we want to hint whether the
patch needs backporting. 


> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
> ---
>  arch/powerpc/mm/pgtable.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
> index cb39c8b..a03ff3d 100644
> --- a/arch/powerpc/mm/pgtable.c
> +++ b/arch/powerpc/mm/pgtable.c
> @@ -193,9 +193,7 @@ void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep,
>  	 */
>  	VM_WARN_ON(pte_present(*ptep) && !pte_protnone(*ptep));
>
> -	/*
> -	 * Add the pte bit when tryint set a pte
> -	 */
> +	/* Add the pte bit when trying to set a pte */
>  	pte = __pte(pte_val(pte) | _PAGE_PTE);
>
>  	/* Note: mm->context.id might not yet have been assigned as
> -- 
> 2.7.4

Re: [PATCH] powerpc/mm: Fix typo in set_pte_at()

[Gavin Shan]

On Mon, Feb 06, 2017 at 08:03:57AM +0530, Aneesh Kumar K.V wrote:
>Gavin Shan <gwshan@linux.vnet.ibm.com> writes:
>
>> This fixes the typo about the _PAGE_PTE in set_pte_at() by changing
>> "tryint" to "trying to".
>>
>> Fixes: 6a119eae942 ("powerpc/mm: Add a _PAGE_PTE bit")
>
>I guess this is not needed. We add that when we want to hint whether the
>patch needs backporting. 
>

Thanks for review. I used the tag to indicate the commit introducing
the typo. For this trivial patch, we won't backport it to table or
distro. If you want, I can drop the tag or Michael helps to drop it
when merging it.

Thanks,
Gavin

>
>> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> ---
>>  arch/powerpc/mm/pgtable.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
>> index cb39c8b..a03ff3d 100644
>> --- a/arch/powerpc/mm/pgtable.c
>> +++ b/arch/powerpc/mm/pgtable.c
>> @@ -193,9 +193,7 @@ void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep,
>>  	 */
>>  	VM_WARN_ON(pte_present(*ptep) && !pte_protnone(*ptep));
>>
>> -	/*
>> -	 * Add the pte bit when tryint set a pte
>> -	 */
>> +	/* Add the pte bit when trying to set a pte */
>>  	pte = __pte(pte_val(pte) | _PAGE_PTE);
>>
>>  	/* Note: mm->context.id might not yet have been assigned as
>> -- 
>> 2.7.4

Re: [PATCH] powerpc/mm: Fix typo in set_pte_at()

[Gavin Shan]

On Mon, Feb 06, 2017 at 08:03:57AM +0530, Aneesh Kumar K.V wrote:
>Gavin Shan <gwshan@linux.vnet.ibm.com> writes:
>
>> This fixes the typo about the _PAGE_PTE in set_pte_at() by changing
>> "tryint" to "trying to".
>>
>> Fixes: 6a119eae942 ("powerpc/mm: Add a _PAGE_PTE bit")
>
>I guess this is not needed. We add that when we want to hint whether the
>patch needs backporting. 
>

I just sent v2 to remove the "Fixes" tag.

Thanks,
Gavin

>
>> Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
>> ---
>>  arch/powerpc/mm/pgtable.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c
>> index cb39c8b..a03ff3d 100644
>> --- a/arch/powerpc/mm/pgtable.c
>> +++ b/arch/powerpc/mm/pgtable.c
>> @@ -193,9 +193,7 @@ void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep,
>>  	 */
>>  	VM_WARN_ON(pte_present(*ptep) && !pte_protnone(*ptep));
>>
>> -	/*
>> -	 * Add the pte bit when tryint set a pte
>> -	 */
>> +	/* Add the pte bit when trying to set a pte */
>>  	pte = __pte(pte_val(pte) | _PAGE_PTE);
>>
>>  	/* Note: mm->context.id might not yet have been assigned as
>> -- 
>> 2.7.4

Re: [PATCH] powerpc/mm: Fix typo in set_pte_at()

[Michael Ellerman]

Gavin Shan <gwshan@linux.vnet.ibm.com> writes:

> On Mon, Feb 06, 2017 at 08:03:57AM +0530, Aneesh Kumar K.V wrote:
>>Gavin Shan <gwshan@linux.vnet.ibm.com> writes:
>>
>>> This fixes the typo about the _PAGE_PTE in set_pte_at() by changing
>>> "tryint" to "trying to".
>>>
>>> Fixes: 6a119eae942 ("powerpc/mm: Add a _PAGE_PTE bit")
>>
>>I guess this is not needed. We add that when we want to hint whether the
>>patch needs backporting. 
>>
>
> I just sent v2 to remove the "Fixes" tag.

OK.

I don't mind if you send a Fixes tag even for a trivial fix like this.

It's not incorrect, this commit does fix that other commit.

It's probably true that we wouldn't backport a trivial fix like that,
but having the Fixes tag means we could if we wanted to. And if we don't
want to backport it then it's harmless extra information.

cheers