From: Russell Currey <ruscur@russell.cc>
To: Michael Neuling <mikey@neuling.org>, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: Detect POWER9 architected mode
Date: Fri, 17 Feb 2017 12:06:04 +1100 [thread overview]
Message-ID: <1487293564.5352.1.camel@russell.cc> (raw)
In-Reply-To: <1487293046.32732.3.camel@neuling.org>
On Fri, 2017-02-17 at 11:57 +1100, Michael Neuling wrote:
> Can you make the comment/title a bit more descriptive... Have a look at
> c674e703cb1028e468527163074810b4a17bf379 where we added the p8.
>
I had a look at that when I was making the commit but I didn't think it really
added anything valuable (though I suppose mentioning cputable in the commit
message might add clarity). I guess
A PVR of 0x0F000005 means we are arch v3.00 compliant (i.e. POWER9)
to steal from yours...
>
> > Signed-off-by: Russell Currey <ruscur@russell.cc>
>
> Other than that, the code looks good..
>
> Acked-By: Michael Neuling <mikey@neuling.org>
>
>
>
> > ---
> > arch/powerpc/kernel/cputable.c | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> >
> > diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c
> > index 6a82ef039c50..d23a54b09436 100644
> > --- a/arch/powerpc/kernel/cputable.c
> > +++ b/arch/powerpc/kernel/cputable.c
> > @@ -386,6 +386,25 @@ static struct cpu_spec __initdata cpu_specs[] = {
> > .machine_check_early =
> > __machine_check_early_realmode_p8,
> > .platform = "power8",
> > },
> > + { /* 3.00-compliant processor, i.e. Power9 "architected"
> > mode
> > */
> > + .pvr_mask = 0xffffffff,
> > + .pvr_value = 0x0f000005,
> > + .cpu_name = "POWER9 (architected)",
> > + .cpu_features = CPU_FTRS_POWER9,
> > + .cpu_user_features = COMMON_USER_POWER9,
> > + .cpu_user_features2 = COMMON_USER2_POWER9,
> > + .mmu_features = MMU_FTRS_POWER9,
> > + .icache_bsize = 128,
> > + .dcache_bsize = 128,
> > + .num_pmcs = 6,
> > + .pmc_type = PPC_PMC_IBM,
> > + .oprofile_cpu_type = "ppc64/ibm-compat-v1",
> > + .oprofile_type = PPC_OPROFILE_INVALID,
> > + .cpu_setup = __setup_cpu_power9,
> > + .cpu_restore = __restore_cpu_power9,
> > + .flush_tlb = __flush_tlb_power9,
> > + .platform = "power9",
> > + },
> > { /* Power7 */
> > .pvr_mask = 0xffff0000,
> > .pvr_value = 0x003f0000,
next prev parent reply other threads:[~2017-02-17 1:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 23:59 [PATCH] powerpc: Detect POWER9 architected mode Russell Currey
2017-02-17 0:57 ` Michael Neuling
2017-02-17 1:06 ` Russell Currey [this message]
2017-02-17 2:44 ` Suraj Jitindar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487293564.5352.1.camel@russell.cc \
--to=ruscur@russell.cc \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox