From: Benjamin Herrenschmidt <benh@au1.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Sachin Sant <sachinp@linux.vnet.ibm.com>,
tglx@linutronix.de
Cc: linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124 .icp_hv_eoi+0x40/0x140
Date: Tue, 21 Feb 2017 07:53:44 +1100 [thread overview]
Message-ID: <1487624024.23576.181.camel@au1.ibm.com> (raw)
In-Reply-To: <87mvdhgmhj.fsf@concordia.ellerman.id.au>
On Mon, 2017-02-20 at 21:55 +1100, Michael Ellerman wrote:
> But when we're called for CONFIG_DEBUG_SHIRQ get_irq() is not called,
> precisely because we're faking an interrupt.
>
> I'm not sure if there's a good way to fix it :/
In the irq_replay path we have code to adjust the CPPR stack. We could
do something similar.
HOWEVER. Looking at current upstream code I don't understand the error,
the DEBUG_SHIRQ code is calling the driver's handler not the flow
handler so it shouldn't be called handle_fasteoi_irq or am I missing
something ?
Cheers,
Ben.
next prev parent reply other threads:[~2017-02-20 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 15:09 [next-20170217] WARN @/arch/powerpc/include/asm/xics.h:124 .icp_hv_eoi+0x40/0x140 Sachin Sant
2017-02-20 2:35 ` Michael Ellerman
2017-02-20 5:04 ` Sachin Sant
2017-02-20 10:55 ` Michael Ellerman
2017-02-20 20:53 ` Benjamin Herrenschmidt [this message]
2017-02-20 22:04 ` Thomas Gleixner
2017-02-20 22:18 ` Benjamin Herrenschmidt
2017-02-20 3:44 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487624024.23576.181.camel@au1.ibm.com \
--to=benh@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=sachinp@linux.vnet.ibm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).