[PATCH kernel 1/1] powerpc/Documentation/misc-devices/: Fix one compile error

[PATCH kernel 1/1] powerpc/Documentation/misc-devices/: Fix one compile error

[fgao]

From: Gao Feng <fgao@ikuai8.com>

When make allyesconfig, there is one compile error on my platform
"gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4".
The following is the output.

Documentation/misc-devices/mei/mei-amt-version.c: In function ‘main’:
Documentation/misc-devices/mei/mei-amt-version.c:103:5: warning: ‘acmd.fd’
is used uninitialized in this function [-Wuninitialized]
  if (cl->fd != -1)
     ^
Documentation/misc-devices/mei/mei-amt-version.c:443:21: note: ‘acmd.fd’
was declared here
  struct amt_host_if acmd;
                     ^
This commit fixes this compile error.

Signed-off-by: Gao Feng <fgao@ikuai8.com>
---
 Documentation/misc-devices/mei/mei-amt-version.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/misc-devices/mei/mei-amt-version.c b/Documentation/misc-devices/mei/mei-amt-version.c
index 49e4f77..ca035cb 100644
--- a/Documentation/misc-devices/mei/mei-amt-version.c
+++ b/Documentation/misc-devices/mei/mei-amt-version.c
@@ -297,6 +297,7 @@ static bool amt_host_if_init(struct amt_host_if *acmd,
 		      unsigned long send_timeout, bool verbose)
 {
 	acmd->send_timeout = (send_timeout) ? send_timeout : 20000;
+	acmd->mei_cl.fd = -1;
 	acmd->initialized = mei_init(&acmd->mei_cl, &MEI_IAMTHIF, 0, verbose);
 	return acmd->initialized;
 }
-- 
1.9.1

Re: [PATCH kernel 1/1] powerpc/Documentation/misc-devices/: Fix one compile error

[Winkler, Tomas]

T24gV2VkLCAyMDE3LTAyLTIyIGF0IDE1OjIyICswODAwLCBmZ2FvQGlrdWFpOC5jb20gd3JvdGU6
DQo+IEZyb206IEdhbyBGZW5nIDxmZ2FvQGlrdWFpOC5jb20+DQo+IA0KPiBXaGVuIG1ha2UgYWxs
eWVzY29uZmlnLCB0aGVyZSBpcyBvbmUgY29tcGlsZSBlcnJvciBvbiBteSBwbGF0Zm9ybQ0KPiAi
Z2NjIChVYnVudHUgNC44LjQtMnVidW50dTF+MTQuMDQuMykgNC44LjQiLg0KPiBUaGUgZm9sbG93
aW5nIGlzIHRoZSBvdXRwdXQuDQo+IA0KPiBEb2N1bWVudGF0aW9uL21pc2MtZGV2aWNlcy9tZWkv
bWVpLWFtdC12ZXJzaW9uLmM6IEluIGZ1bmN0aW9uIOKAmG1haW7igJk6DQo+IERvY3VtZW50YXRp
b24vbWlzYy1kZXZpY2VzL21laS9tZWktYW10LXZlcnNpb24uYzoxMDM6NTogd2FybmluZzoNCj4g
4oCYYWNtZC5mZOKAmQ0KPiBpcyB1c2VkIHVuaW5pdGlhbGl6ZWQgaW4gdGhpcyBmdW5jdGlvbiBb
LVd1bmluaXRpYWxpemVkXQ0KPiDCoCBpZiAoY2wtPmZkICE9IC0xKQ0KPiDCoMKgwqDCoMKgXg0K
PiBEb2N1bWVudGF0aW9uL21pc2MtZGV2aWNlcy9tZWkvbWVpLWFtdC12ZXJzaW9uLmM6NDQzOjIx
OiBub3RlOg0KPiDigJhhY21kLmZk4oCZDQo+IHdhcyBkZWNsYXJlZCBoZXJlDQo+IMKgIHN0cnVj
dCBhbXRfaG9zdF9pZiBhY21kOw0KPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg
wqDCoMKgwqBeDQo+IFRoaXMgY29tbWl0IGZpeGVzIHRoaXMgY29tcGlsZSBlcnJvci4NCj4gDQo+
IFNpZ25lZC1vZmYtYnk6IEdhbyBGZW5nIDxmZ2FvQGlrdWFpOC5jb20+DQoNClRoaXMgaXMgZmFs
c2UgcG9zaXRpdmUsIGFzIHRoZSB2YXJpYWJsZSBpcyBhc3NpbmVkIGluIG1laV9pbml0KCksIGlu
DQphbnkgY2FzZSwgdGhlIGNvZGUgaGFzIG1vdmVkIHVuZGVyIHNhbXBsZXMgZGlyZXRvcnkgaW4g
dGhlIGN1cnJlbnQNCmtlcm5lbC4gQW55dGhpbmcgbmVlZCB0byBiZSBmaXhlZCB0aGVyZSBmaXJz
dA0KDQpUaGFua3PCoA0KVG9tYXMNCg0KPiAtLS0NCj4gwqBEb2N1bWVudGF0aW9uL21pc2MtZGV2
aWNlcy9tZWkvbWVpLWFtdC12ZXJzaW9uLmMgfCAxICsNCj4gwqAxIGZpbGUgY2hhbmdlZCwgMSBp
bnNlcnRpb24oKykNCj4gDQo+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL21pc2MtZGV2aWNl
cy9tZWkvbWVpLWFtdC12ZXJzaW9uLmMNCj4gYi9Eb2N1bWVudGF0aW9uL21pc2MtZGV2aWNlcy9t
ZWkvbWVpLWFtdC12ZXJzaW9uLmMNCj4gaW5kZXggNDllNGY3Ny4uY2EwMzVjYiAxMDA2NDQNCj4g
LS0tIGEvRG9jdW1lbnRhdGlvbi9taXNjLWRldmljZXMvbWVpL21laS1hbXQtdmVyc2lvbi5jDQo+
ICsrKyBiL0RvY3VtZW50YXRpb24vbWlzYy1kZXZpY2VzL21laS9tZWktYW10LXZlcnNpb24uYw0K
PiBAQCAtMjk3LDYgKzI5Nyw3IEBAIHN0YXRpYyBib29sIGFtdF9ob3N0X2lmX2luaXQoc3RydWN0
IGFtdF9ob3N0X2lmDQo+ICphY21kLA0KPiDCoAkJwqDCoMKgwqDCoMKgdW5zaWduZWQgbG9uZyBz
ZW5kX3RpbWVvdXQsIGJvb2wgdmVyYm9zZSkNCj4gwqB7DQo+IMKgCWFjbWQtPnNlbmRfdGltZW91
dCA9IChzZW5kX3RpbWVvdXQpID8gc2VuZF90aW1lb3V0IDogMjAwMDA7DQo+ICsJYWNtZC0+bWVp
X2NsLmZkID0gLTE7DQo+IMKgCWFjbWQtPmluaXRpYWxpemVkID0gbWVpX2luaXQoJmFjbWQtPm1l
aV9jbCwgJk1FSV9JQU1USElGLCAwLA0KPiB2ZXJib3NlKTsNCj4gwqAJcmV0dXJuIGFjbWQtPmlu
aXRpYWxpemVkOw0KPiDCoH0=

Re: [PATCH kernel 1/1] powerpc/Documentation/misc-devices/: Fix one compile error

[Feng Gao]

On Wed, Feb 22, 2017 at 4:14 PM, Winkler, Tomas <tomas.winkler@intel.com> w=
rote:
> On Wed, 2017-02-22 at 15:22 +0800, fgao@ikuai8.com wrote:
>> From: Gao Feng <fgao@ikuai8.com>
>>
>> When make allyesconfig, there is one compile error on my platform
>> "gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4".
>> The following is the output.
>>
>> Documentation/misc-devices/mei/mei-amt-version.c: In function =E2=80=98m=
ain=E2=80=99:
>> Documentation/misc-devices/mei/mei-amt-version.c:103:5: warning:
>> =E2=80=98acmd.fd=E2=80=99
>> is used uninitialized in this function [-Wuninitialized]
>>   if (cl->fd !=3D -1)
>>      ^
>> Documentation/misc-devices/mei/mei-amt-version.c:443:21: note:
>> =E2=80=98acmd.fd=E2=80=99
>> was declared here
>>   struct amt_host_if acmd;
>>                      ^
>> This commit fixes this compile error.
>>
>> Signed-off-by: Gao Feng <fgao@ikuai8.com>
>
> This is false positive, as the variable is assined in mei_init(), in
> any case, the code has moved under samples diretory in the current
> kernel. Anything need to be fixed there first
>
> Thanks
> Tomas

I think it is not false positive.
The function stack is main->amt_host_if_init->mei_init->mei_deinit.
There is one check "if (cl->fd !=3D -1)".

Because this fd is not initialized to -1, so it may hit the condition,
and execute close.

So it should be fixed, although these codes would be moved to sample direct=
or.

Regards
Feng

>
>> ---
>>  Documentation/misc-devices/mei/mei-amt-version.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/misc-devices/mei/mei-amt-version.c
>> b/Documentation/misc-devices/mei/mei-amt-version.c
>> index 49e4f77..ca035cb 100644
>> --- a/Documentation/misc-devices/mei/mei-amt-version.c
>> +++ b/Documentation/misc-devices/mei/mei-amt-version.c
>> @@ -297,6 +297,7 @@ static bool amt_host_if_init(struct amt_host_if
>> *acmd,
>>                     unsigned long send_timeout, bool verbose)
>>  {
>>       acmd->send_timeout =3D (send_timeout) ? send_timeout : 20000;
>> +     acmd->mei_cl.fd =3D -1;
>>       acmd->initialized =3D mei_init(&acmd->mei_cl, &MEI_IAMTHIF, 0,
>> verbose);
>>       return acmd->initialized;
>>  }

RE: [PATCH kernel 1/1] powerpc/Documentation/misc-devices/: Fix one compile error

[Winkler, Tomas]

DQo+IA0KPiBPbiBXZWQsIEZlYiAyMiwgMjAxNyBhdCA0OjE0IFBNLCBXaW5rbGVyLCBUb21hcyA8
dG9tYXMud2lua2xlckBpbnRlbC5jb20+DQo+IHdyb3RlOg0KPiA+IE9uIFdlZCwgMjAxNy0wMi0y
MiBhdCAxNToyMiArMDgwMCwgZmdhb0Bpa3VhaTguY29tIHdyb3RlOg0KPiA+PiBGcm9tOiBHYW8g
RmVuZyA8Zmdhb0Bpa3VhaTguY29tPg0KPiA+Pg0KPiA+PiBXaGVuIG1ha2UgYWxseWVzY29uZmln
LCB0aGVyZSBpcyBvbmUgY29tcGlsZSBlcnJvciBvbiBteSBwbGF0Zm9ybQ0KPiA+PiAiZ2NjIChV
YnVudHUgNC44LjQtMnVidW50dTF+MTQuMDQuMykgNC44LjQiLg0KPiA+PiBUaGUgZm9sbG93aW5n
IGlzIHRoZSBvdXRwdXQuDQo+ID4+DQo+ID4+IERvY3VtZW50YXRpb24vbWlzYy1kZXZpY2VzL21l
aS9tZWktYW10LXZlcnNpb24uYzogSW4gZnVuY3Rpb24g4oCYbWFpbuKAmToNCj4gPj4gRG9jdW1l
bnRhdGlvbi9taXNjLWRldmljZXMvbWVpL21laS1hbXQtdmVyc2lvbi5jOjEwMzo1OiB3YXJuaW5n
Og0KPiA+PiDigJhhY21kLmZk4oCZDQo+ID4+IGlzIHVzZWQgdW5pbml0aWFsaXplZCBpbiB0aGlz
IGZ1bmN0aW9uIFstV3VuaW5pdGlhbGl6ZWRdDQo+ID4+ICAgaWYgKGNsLT5mZCAhPSAtMSkNCj4g
Pj4gICAgICBeDQo+ID4+IERvY3VtZW50YXRpb24vbWlzYy1kZXZpY2VzL21laS9tZWktYW10LXZl
cnNpb24uYzo0NDM6MjE6IG5vdGU6DQo+ID4+IOKAmGFjbWQuZmTigJkNCj4gPj4gd2FzIGRlY2xh
cmVkIGhlcmUNCj4gPj4gICBzdHJ1Y3QgYW10X2hvc3RfaWYgYWNtZDsNCj4gPj4gICAgICAgICAg
ICAgICAgICAgICAgXg0KPiA+PiBUaGlzIGNvbW1pdCBmaXhlcyB0aGlzIGNvbXBpbGUgZXJyb3Iu
DQo+ID4+DQo+ID4+IFNpZ25lZC1vZmYtYnk6IEdhbyBGZW5nIDxmZ2FvQGlrdWFpOC5jb20+DQo+
ID4NCj4gPiBUaGlzIGlzIGZhbHNlIHBvc2l0aXZlLCBhcyB0aGUgdmFyaWFibGUgaXMgYXNzaW5l
ZCBpbiBtZWlfaW5pdCgpLCBpbg0KPiA+IGFueSBjYXNlLCB0aGUgY29kZSBoYXMgbW92ZWQgdW5k
ZXIgc2FtcGxlcyBkaXJldG9yeSBpbiB0aGUgY3VycmVudA0KPiA+IGtlcm5lbC4gQW55dGhpbmcg
bmVlZCB0byBiZSBmaXhlZCB0aGVyZSBmaXJzdA0KPiA+DQo+ID4gVGhhbmtzDQo+ID4gVG9tYXMN
Cj4gDQo+IEkgdGhpbmsgaXQgaXMgbm90IGZhbHNlIHBvc2l0aXZlLg0KPiBUaGUgZnVuY3Rpb24g
c3RhY2sgaXMgbWFpbi0+YW10X2hvc3RfaWZfaW5pdC0+bWVpX2luaXQtPm1laV9kZWluaXQuDQo+
IFRoZXJlIGlzIG9uZSBjaGVjayAiaWYgKGNsLT5mZCAhPSAtMSkiLg0KDQpJc24ndCAgdGhlIGZp
cnN0IGxpbmUgaW4gbWVpX2luaXQgbWUtPmZkID0gb3BlbigiL2Rldi9tZWkiLCBPX1JEV1IpOyA/
IA0KSSBkb24ndCBzZWUgbWVpX2RlaW5pdCBjYWxsZWQgdy9vIG1laV9pbml0IGNhbGxlZCBmaXJz
dC4gDQogDQo+IEJlY2F1c2UgdGhpcyBmZCBpcyBub3QgaW5pdGlhbGl6ZWQgdG8gLTEsIHNvIGl0
IG1heSBoaXQgdGhlIGNvbmRpdGlvbiwgYW5kIGV4ZWN1dGUNCj4gY2xvc2UuDQo+IA0KPiBTbyBp
dCBzaG91bGQgYmUgZml4ZWQsIGFsdGhvdWdoIHRoZXNlIGNvZGVzIHdvdWxkIGJlIG1vdmVkIHRv
IHNhbXBsZQ0KPiBkaXJlY3Rvci4NCg0KUGxlYXNlIHRyeSB3aXRoIHRoZSBtYXN0ZXIgYnJhbmNo
IGZpcnN0IGluIGNhc2UgIEknbSBzdGlsbCB3cm9uZy4NClRoYW5rcw0KIA0KPiBSZWdhcmRzDQo+
IEZlbmcNCj4gDQo+ID4NCj4gPj4gLS0tDQo+ID4+ICBEb2N1bWVudGF0aW9uL21pc2MtZGV2aWNl
cy9tZWkvbWVpLWFtdC12ZXJzaW9uLmMgfCAxICsNCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGlu
c2VydGlvbigrKQ0KPiA+Pg0KPiA+PiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9taXNjLWRl
dmljZXMvbWVpL21laS1hbXQtdmVyc2lvbi5jDQo+ID4+IGIvRG9jdW1lbnRhdGlvbi9taXNjLWRl
dmljZXMvbWVpL21laS1hbXQtdmVyc2lvbi5jDQo+ID4+IGluZGV4IDQ5ZTRmNzcuLmNhMDM1Y2Ig
MTAwNjQ0DQo+ID4+IC0tLSBhL0RvY3VtZW50YXRpb24vbWlzYy1kZXZpY2VzL21laS9tZWktYW10
LXZlcnNpb24uYw0KPiA+PiArKysgYi9Eb2N1bWVudGF0aW9uL21pc2MtZGV2aWNlcy9tZWkvbWVp
LWFtdC12ZXJzaW9uLmMNCj4gPj4gQEAgLTI5Nyw2ICsyOTcsNyBAQCBzdGF0aWMgYm9vbCBhbXRf
aG9zdF9pZl9pbml0KHN0cnVjdCBhbXRfaG9zdF9pZg0KPiA+PiAqYWNtZCwNCj4gPj4gICAgICAg
ICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHNlbmRfdGltZW91dCwgYm9vbCB2ZXJib3NlKSAg
ew0KPiA+PiAgICAgICBhY21kLT5zZW5kX3RpbWVvdXQgPSAoc2VuZF90aW1lb3V0KSA/IHNlbmRf
dGltZW91dCA6IDIwMDAwOw0KPiA+PiArICAgICBhY21kLT5tZWlfY2wuZmQgPSAtMTsNCj4gPj4g
ICAgICAgYWNtZC0+aW5pdGlhbGl6ZWQgPSBtZWlfaW5pdCgmYWNtZC0+bWVpX2NsLCAmTUVJX0lB
TVRISUYsIDAsDQo+ID4+IHZlcmJvc2UpOw0KPiA+PiAgICAgICByZXR1cm4gYWNtZC0+aW5pdGlh
bGl6ZWQ7DQo+ID4+ICB9DQo=

Re: [PATCH kernel 1/1] powerpc/Documentation/misc-devices/: Fix one compile error

[Feng Gao]

On Wed, Feb 22, 2017 at 5:09 PM, Winkler, Tomas <tomas.winkler@intel.com> w=
rote:
>
>>
>> On Wed, Feb 22, 2017 at 4:14 PM, Winkler, Tomas <tomas.winkler@intel.com=
>
>> wrote:
>> > On Wed, 2017-02-22 at 15:22 +0800, fgao@ikuai8.com wrote:
>> >> From: Gao Feng <fgao@ikuai8.com>
>> >>
>> >> When make allyesconfig, there is one compile error on my platform
>> >> "gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4".
>> >> The following is the output.
>> >>
>> >> Documentation/misc-devices/mei/mei-amt-version.c: In function =E2=80=
=98main=E2=80=99:
>> >> Documentation/misc-devices/mei/mei-amt-version.c:103:5: warning:
>> >> =E2=80=98acmd.fd=E2=80=99
>> >> is used uninitialized in this function [-Wuninitialized]
>> >>   if (cl->fd !=3D -1)
>> >>      ^
>> >> Documentation/misc-devices/mei/mei-amt-version.c:443:21: note:
>> >> =E2=80=98acmd.fd=E2=80=99
>> >> was declared here
>> >>   struct amt_host_if acmd;
>> >>                      ^
>> >> This commit fixes this compile error.
>> >>
>> >> Signed-off-by: Gao Feng <fgao@ikuai8.com>
>> >
>> > This is false positive, as the variable is assined in mei_init(), in
>> > any case, the code has moved under samples diretory in the current
>> > kernel. Anything need to be fixed there first
>> >
>> > Thanks
>> > Tomas
>>
>> I think it is not false positive.
>> The function stack is main->amt_host_if_init->mei_init->mei_deinit.
>> There is one check "if (cl->fd !=3D -1)".
>
> Isn't  the first line in mei_init me->fd =3D open("/dev/mei", O_RDWR); ?
> I don't see mei_deinit called w/o mei_init called first.

The codes of powerpc.git(git://git.kernel.org/pub/scm/linux/kernel/git/gala=
k/powerpc.git)
are different with net.git.
The following are the codes from powerpc.git

static bool mei_init(struct mei *me, const uuid_le *guid,
                unsigned char req_protocol_version, bool verbose)
{
        int result;
        struct mei_client *cl;
        struct mei_connect_client_data data;

        mei_deinit(me);

        me->verbose =3D verbose;

        me->fd =3D open("/dev/mei", O_RDWR);
        if (me->fd =3D=3D -1) {
                mei_err(me, "Cannot establish a handle to the Intel
MEI driver\n");
                goto err;
        }

The mei_deinit is invoked before open, so the gcc reports one warning.

Regards
Feng


>
>> Because this fd is not initialized to -1, so it may hit the condition, a=
nd execute
>> close.
>>
>> So it should be fixed, although these codes would be moved to sample
>> director.
>
> Please try with the master branch first in case  I'm still wrong.
> Thanks
>
>> Regards
>> Feng
>>
>> >
>> >> ---
>> >>  Documentation/misc-devices/mei/mei-amt-version.c | 1 +
>> >>  1 file changed, 1 insertion(+)
>> >>
>> >> diff --git a/Documentation/misc-devices/mei/mei-amt-version.c
>> >> b/Documentation/misc-devices/mei/mei-amt-version.c
>> >> index 49e4f77..ca035cb 100644
>> >> --- a/Documentation/misc-devices/mei/mei-amt-version.c
>> >> +++ b/Documentation/misc-devices/mei/mei-amt-version.c
>> >> @@ -297,6 +297,7 @@ static bool amt_host_if_init(struct amt_host_if
>> >> *acmd,
>> >>                     unsigned long send_timeout, bool verbose)  {
>> >>       acmd->send_timeout =3D (send_timeout) ? send_timeout : 20000;
>> >> +     acmd->mei_cl.fd =3D -1;
>> >>       acmd->initialized =3D mei_init(&acmd->mei_cl, &MEI_IAMTHIF, 0,
>> >> verbose);
>> >>       return acmd->initialized;
>> >>  }